Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 576105 - Potential problem with RemoveBendpointsOperation that rollbacks the transaction
Summary: Potential problem with RemoveBendpointsOperation that rollbacks the transaction
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 5.1.0   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 6.6.0   Edit
Assignee: Laurent Redor CLA
QA Contact: Glenn Plouhinec CLA
URL:
Whiteboard:
Keywords:
Depends on: 518136
Blocks: 576138
  Show dependency tree
 
Reported: 2021-09-20 05:53 EDT by Laurent Redor CLA
Modified: 2021-12-10 04:07 EST (History)
1 user (show)

See Also:

Attachments
RemoveObliqueBendpoints.zip (3.74 KB, application/x-zip-compressed)
2021-09-20 05:53 EDT, Laurent Redor CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2021-09-20 05:53:40 EDT 
Created attachment 287169 [details]
RemoveObliqueBendpoints.zip

This problem has been observed during an ELK layout (so the layout is aborted without explanation; arrange all is not executed and nothing in the Error Log view).

The problem can be reproduce with more simple steps:
* Import project RemoveObliqueBendpoints
* Open the diagram "new Diag": In this diagram, 2 nodes are overlapped (same bounds). And the edge connects these 2 nodes.
* Select the edge.
* Change the "routing style" of the edge to oblique.
* KO: 
    * The diagram is not dirty,
    * there is no command to undo in the history,
    * and if you try to create a bendpoint, the routing is always rectilinear.
Comment 1 Laurent Redor CLA 2021-09-20 09:29:58 EDT 
This problem seems to be here since bug 518136.
Comment 2 Eclipse Genie CLA 2021-09-20 09:41:20 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/185604
Comment 3 Eclipse Genie CLA 2021-09-20 09:41:22 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/185605
Comment 6 Laurent Redor CLA 2021-09-21 04:55:10 EDT 
Steps to validate:
* Import project RemoveObliqueBendpoints
* Open the diagram "new Diag": In this diagram, 2 nodes are overlapped (same bounds). And the edge connects these 2 nodes.
* Select the edge.
* Change the "routing style" of the edge to oblique.
* Expected: 
    * The diagram is dirty,
    * there is a command to undo in the history,
    * there is no visual change, 
    * but if you try to create a bendpoint, you notice that the routing is now oblique.
Comment 7 Glenn Plouhinec CLA 2021-10-19 10:16:00 EDT 
Validated with ODCE 11.6.0 IT1
Comment 8 Pierre-Charles David CLA 2021-12-10 04:07:07 EST 
Available in Sirius 6.6.0: https://projects.eclipse.org/projects/modeling.sirius/releases/6.6.0