Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 57306 - Improve progress feedback when user wants to wait on build before a launch
Summary: Improve progress feedback when user wants to wait on build before a launch
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: 3.0 M9   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-02 15:46 EST by Erich Gamma CLA
Modified: 2004-04-19 22:34 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erich Gamma CLA 2004-04-02 15:46:29 EST 
(marked as major since improving the feedback from back ground jobs has a high 
priority for 3.0)

1) press run while the auto build is still running
2) The user is prompted whether they want to wait
3) press yes

Problem there is no progress feedback after this point. 
You have to open the progress view to understand how long you will have to 
wait.

The proposal is to show a ProgressMonitorJobsDialog when
the auto build is still running. This will provide
the user with a progess indication.
Comment 1 Erich Gamma CLA 2004-04-02 15:47:38 EST 
CCing Tod he implemented the Jobs progress dialog and can provide support.
Comment 2 Darin Wright CLA 2004-04-07 17:56:20 EDT 
Erich, do you want the "Blocked" dialog, or the "Run in background" dialog?
Comment 3 Erich Gamma CLA 2004-04-08 05:31:19 EDT 
The dialog should be the ProgressMonitorFocusJobDialog with the focus on the 
build job. We want to minimize the Blocked dialog.

However, this class currently isn't API. Tod what do you recommend? Could you 
make this class API?
Comment 4 Tod Creasey CLA 2004-04-08 07:59:06 EDT 
I see no reason why not. I haven't yet as I wanted some flexibility in the 
class.  Does anyone have an idea for a better name? 
ProgressMonitorFocusJobDialog is a bit of a mouthful.
Comment 5 Darin Wright CLA 2004-04-08 08:47:59 EDT 
At a glance, it looks like a progress dialog for a job - so something 
like "JobProgressMonitorDialog" would make sense to me (unless you want all 
progress dialogs to being with "ProgressDialog").
Comment 6 Kevin Barnes CLA 2004-04-16 12:13:24 EDT 
Made changes to use IProgressService to display progress of launches better.
Changes to:
DebugUIMessages.properties, DebugUIPlugin, DebugUITools
LaunchConfigurationsDialog (now launches using DebugUITools.launch() instead of internal methods)
ProjectCreationDecorator (set PREF_WAIT_FOR_BUILDS to "Always" to prevent dialog during test runs)
Comment 7 Kevin Barnes CLA 2004-04-16 12:14:05 EDT 
Darin, please verify
Comment 8 Darin Wright CLA 2004-04-17 22:26:12 EDT 
Verified the new progress dialog appears, but we are too agressive. The dialog 
appears even if a build is not in progress. I think the launch should be a 
background job with no dialog, unless there is a build job in progres (then we 
want the feedback).
Comment 9 Kevin Barnes CLA 2004-04-19 12:04:08 EDT 
Fixed in DebugUIPlugin. Dialog is only shown for background launches when there are builds in 
progress and the user wants to wait for them to complete.
Comment 10 Kevin Barnes CLA 2004-04-19 12:05:07 EDT 
Darin, please verify
Comment 11 Darin Wright CLA 2004-04-19 22:30:45 EDT 
Verified. Found one bug which I will file seperately.
Comment 12 Darin Wright CLA 2004-04-19 22:34:05 EDT 
Reference to the new bug I filed: bug 59183.