Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 572036 - Update org.eclipse.compare code
Summary: Update org.eclipse.compare code
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 4.18   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.20 M1   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 571954
Blocks:
  Show dependency tree
 
Reported: 2021-03-17 11:33 EDT by Lars Vogel CLA
Modified: 2021-04-07 07:34 EDT (History)
2 users (show)

See Also:

Attachments
Screenshot for the button which are affected by the pack call (43.78 KB, image/png)
2021-03-17 11:48 EDT, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2021-03-17 11:33:19 EDT 
IMHO the Eclipse compare code is very slow, which kind of "forces" me to use Gerrit for reviewing my changes.


I use this bug for trying to improve the code a bit, maybe this offers options to make the code also faster.

Contributions are welcome
Comment 1 Lars Vogel CLA 2021-03-17 11:34:45 EDT 
Adding Jörg, as he may also like to improve this code performance wise.
Comment 2 Jörg Kubitz CLA 2021-03-17 11:36:55 EDT 
> Adding Jörg, as he may also like to improve this code performance wise.

:-)
Comment 3 Lars Vogel CLA 2021-03-17 11:48:39 EDT 
Created attachment 285860 [details]
Screenshot for the button which are affected by the pack call

The pack call seems unnecessary
Comment 4 Eclipse Genie CLA 2021-03-17 11:48:59 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/177927
Comment 5 Eclipse Genie CLA 2021-03-17 11:50:12 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/177928
Comment 6 Eclipse Genie CLA 2021-03-17 11:56:20 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/177929
Comment 7 Eclipse Genie CLA 2021-03-17 11:59:55 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/177930