Comment 1 Mauro Garcia 2021-01-28 12:29:41 EST

Hi! I'm Mauro García from Equo. I created a gerrit https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/175450 with missing functions to download and find. I will be monitoring the Chromium status in SWT and will be uploading other patches with critical fixes.

Comment 2 Holger Voormann 2021-02-18 03:12:55 EST

Hi Mauro,

Since no binaries are built by the Gerrit change yet, could you please attache the org.eclipse.swt.browser.chromium.win32.win32.x86_64 fragment and the fragments for the other platforms to this bug? I'm working as a freelancer for Advantest and I would like to review your Gerrit change, using the outcome if possible. It would be great if this change would make it in 4.19, but there are only a few days left to do so.

Maybe you could also help, to make Gerrit changes containing org.eclipse.swt.browser.chromium changes trigger the downstream/subprojects of the Jenkins job <https://ci.eclipse.org/releng/job/1-SWT-Increment_if_needed_chromium/>.

Thanks in advance!

Comment 3 Sravan Kumar Lakkimsetti 2021-02-18 06:38:41 EST

(In reply to Holger Voormann from comment #2)
> Hi Mauro,
> 
> Since no binaries are built by the Gerrit change yet, could you please
> attache the org.eclipse.swt.browser.chromium.win32.win32.x86_64 fragment and
> the fragments for the other platforms to this bug? I'm working as a
> freelancer for Advantest and I would like to review your Gerrit change,
> using the outcome if possible. It would be great if this change would make
> it in 4.19, but there are only a few days left to do so.
> 
> Maybe you could also help, to make Gerrit changes containing
> org.eclipse.swt.browser.chromium changes trigger the downstream/subprojects
> of the Jenkins job
> <https://ci.eclipse.org/releng/job/1-SWT-Increment_if_needed_chromium/>.
> 
> Thanks in advance!

Hi Holger,

if you branch out 
eclipse.platform.swt.binaries.git and
eclipse.platform.swt.git
with same branch name, you can use https://ci.eclipse.org/releng/job/SWT-Increment_chromium-maintenance/ to build native libraries. 

This job will build native libraries and commit them to the binaries repo(in the specified branch).

Thanks

Comment 4 Mauro Garcia 2021-02-26 15:01:09 EST

@Holger Voormann

Hi!.I enclose the fragments together with the jars inside each one.

https://drive.google.com/drive/folders/1yjadosyxwvCz0qUUZ04AxOnpIWNIhNch?usp=sharing

Comment 5 Eclipse Genie 2021-03-10 13:26:20 EST

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/175450

Comment 6 Mauro Garcia 2021-03-10 13:28:35 EST

(In reply to Holger Voormann from comment #2)
> Hi Mauro,
> 
> Since no binaries are built by the Gerrit change yet, could you please
> attache the org.eclipse.swt.browser.chromium.win32.win32.x86_64 fragment and
> the fragments for the other platforms to this bug? I'm working as a
> freelancer for Advantest and I would like to review your Gerrit change,
> using the outcome if possible. It would be great if this change would make
> it in 4.19, but there are only a few days left to do so.
> 
> Maybe you could also help, to make Gerrit changes containing
> org.eclipse.swt.browser.chromium changes trigger the downstream/subprojects
> of the Jenkins job
> <https://ci.eclipse.org/releng/job/1-SWT-Increment_if_needed_chromium/>.
> 
> Thanks in advance!


Holger!, I attach the updated fragment for linux.


https://drive.google.com/file/d/1SwnzO3I_E3iCBWU7T2wxvLir9fjP8hXk/view?usp=sharing

Comment 7 Holger Voormann 2021-03-23 03:20:19 EDT

(In reply to Mauro Garcia from comment #6)
> (In reply to Holger Voormann from comment #2)
> > Hi Mauro,
> > 
> > Since no binaries are built by the Gerrit change yet, could you please
> > attache the org.eclipse.swt.browser.chromium.win32.win32.x86_64 fragment and
> > the fragments for the other platforms to this bug? I'm working as a
> > freelancer for Advantest and I would like to review your Gerrit change,
> > using the outcome if possible. It would be great if this change would make
> > it in 4.19, but there are only a few days left to do so.
> > 
> > Maybe you could also help, to make Gerrit changes containing
> > org.eclipse.swt.browser.chromium changes trigger the downstream/subprojects
> > of the Jenkins job
> > <https://ci.eclipse.org/releng/job/1-SWT-Increment_if_needed_chromium/>.
> > 
> > Thanks in advance!
> 
> 
> Holger!, I attach the updated fragment for linux.
> 
> 
> https://drive.google.com/file/d/1SwnzO3I_E3iCBWU7T2wxvLir9fjP8hXk/
> view?usp=sharing

We (Advantest) need them for Windows too.

Please provide a GitHub repository that builds the binaries via GitHub actions. I have tried it, but without success so far: https://github.com/howlger/Eclipse-Chromium-Build

Comment 8 Holger Voormann 2021-03-24 03:40:21 EDT

(In reply to Mauro Garcia from comment #6)
> 
> Holger!, I attach the updated fragment for linux.
> 
> 
> https://drive.google.com/file/d/1SwnzO3I_E3iCBWU7T2wxvLir9fjP8hXk/
> view?usp=sharing
As also confirmed by Equo, this fragment for Linux does not work with Eclipse 4.19.

Comment 9 Alexander Kurtakov 2021-10-04 04:55:33 EDT

Chromium has been removed via bug 572010 .