Community
Participate
Working Groups
As discussed on cross-project-issues-dev, we will attempt to upgrade our Gerrit ECA plugin today: https://www.eclipse.org/lists/cross-project-issues-dev/msg18086.html I would like to leverage this bug to report any issue with the upgrade. It's crucial that the service is stable during the upcoming holidays. If we are not successful today, we will revert to the current version and we won't try this again until the new year! @Martin, can you please a link to the release and artifact to deploy? @Webmaster, can you please update the Gerrit ECA plugin @ 18:00 GMT which is 1:00 pm in Ottawa.
*** Bug 569702 has been marked as a duplicate of this bug. ***
(In reply to Christopher Guindon from comment #0) > As discussed on cross-project-issues-dev, we will attempt to upgrade our > Gerrit ECA plugin today: > https://www.eclipse.org/lists/cross-project-issues-dev/msg18086.html > > I would like to leverage this bug to report any issue with the upgrade. > > It's crucial that the service is stable during the upcoming holidays. If we > are not successful today, we will revert to the current version and we won't > try this again until the new year! > > @Martin, can you please a link to the release and artifact to deploy? > > @Webmaster, can you please update the Gerrit ECA plugin @ 18:00 GMT which is > 1:00 pm in Ottawa. Here is the release! https://github.com/EclipseFdn/gerrit-eca-plugin/releases/tag/1.0.16
Created attachment 285032 [details] Release JAR
The plugin is now available on production! Please report issues by leaving a comment on this bug.
(In reply to Christopher Guindon from comment #4) > The plugin is now available on production! > > Please report issues by leaving a comment on this bug. The Hono project's web site build job fails again with the plugin complaining about the bot user having no ECA [1] :-( [1] https://ci.eclipse.org/hono/job/Hono-Website-Declarative-Pipeline/77/console
(In reply to Kai Hudalla from comment #5) > (In reply to Christopher Guindon from comment #4) > > The plugin is now available on production! > > > > Please report issues by leaving a comment on this bug. > > The Hono project's web site build job fails again with the plugin > complaining about the bot user having no ECA [1] :-( > > [1] > https://ci.eclipse.org/hono/job/Hono-Website-Declarative-Pipeline/77/console I'm investigating this now, there may be a hiccup with the API in how it validates bots (rather than the actual plugin). I'll report back here if/when we have a solution!
(In reply to Martin Lowe from comment #6) > (In reply to Kai Hudalla from comment #5) > > (In reply to Christopher Guindon from comment #4) > > > The plugin is now available on production! > > > > > > Please report issues by leaving a comment on this bug. > > > > The Hono project's web site build job fails again with the plugin > > complaining about the bot user having no ECA [1] :-( > > > > [1] > > https://ci.eclipse.org/hono/job/Hono-Website-Declarative-Pipeline/77/console > > I'm investigating this now, there may be a hiccup with the API in how it > validates bots (rather than the actual plugin). I'll report back here > if/when we have a solution! @Kai I've looked into this, and while there is an issue with bots, it's actually not with Gerrit bot validation oddly enough. The issue is that it always uses the bot that would be checked for Gerrit against all services. The issue with the Hono bot is that the Hono website isn't registered as a repository associated with the Hono project. Right now it's just the Hono and the Hono Extras repositories that are registered. If you add the site as a repository associated with the project, it should properly pick up roughly an hour later (caching server side for performance). https://projects.eclipse.org/api/projects/iot_hono
(In reply to Martin Lowe from comment #7) > @Kai > > I've looked into this, and while there is an issue with bots, it's actually > not with Gerrit bot validation oddly enough. The issue is that it always > uses the bot that would be checked for Gerrit against all services. > > The issue with the Hono bot is that the Hono website isn't registered as a > repository associated with the Hono project. Right now it's just the Hono > and the Hono Extras repositories that are registered. If you add the site as > a repository associated with the project, it should properly pick up roughly > an hour later (caching server side for performance). > > https://projects.eclipse.org/api/projects/iot_hono @Martin, thanks for the analysis. Can you also provide a hint for how I can add the missing association? Can I do that myself or do I need to create an issue on Bugzilla? Kai
(In reply to Martin Lowe from comment #7) > (In reply to Martin Lowe from comment #6) > > (In reply to Kai Hudalla from comment #5) > > > (In reply to Christopher Guindon from comment #4) > > > > The plugin is now available on production! > > > > > > > > Please report issues by leaving a comment on this bug. > > > > > > The Hono project's web site build job fails again with the plugin > > > complaining about the bot user having no ECA [1] :-( > > > > > > [1] > > > https://ci.eclipse.org/hono/job/Hono-Website-Declarative-Pipeline/77/console > > > > I'm investigating this now, there may be a hiccup with the API in how it > > validates bots (rather than the actual plugin). I'll report back here > > if/when we have a solution! > > @Kai > > I've looked into this, and while there is an issue with bots, it's actually > not with Gerrit bot validation oddly enough. The issue is that it always > uses the bot that would be checked for Gerrit against all services. > > The issue with the Hono bot is that the Hono website isn't registered as a > repository associated with the Hono project. Right now it's just the Hono > and the Hono Extras repositories that are registered. If you add the site as > a repository associated with the project, it should properly pick up roughly > an hour later (caching server side for performance). > > https://projects.eclipse.org/api/projects/iot_hono Martin that field is not editable by projects. This is reserved for the webmaster team. We don't want to include website repos in there as this is reserved for repos for the project. The website is not part of the project.
Hi All, I spoke to Wayne about this and we agreed that bots owned by the foundation are not required to include a sign-off-by and we can assume that they have an ECA on file: https://api.eclipse.org/bots Basically, we don't need to validate if a bot is associated with a particular project. It's important to note that write access is still managed by LDAP. This will not grant write access to the bots on additional projects. It will simply accept the contribution as valid. The Hono bot will continue to have access to its project. @Wayne can you please +1 this so that we have a paper trail of this conversation? Thanks!
> I spoke to Wayne about this and we agreed that bots owned by the foundation > are not required to include a sign-off-by and we can assume that they have > an ECA on file: https://api.eclipse.org/bots This is based on an assumption that bots are not adding intellectual property. That is, anything that a bot may contribute is expected to be either configuration or content generated from intellectual property that is already available to the project. +1
(In reply to Wayne Beaton from comment #11) > > I spoke to Wayne about this and we agreed that bots owned by the foundation > > are not required to include a sign-off-by and we can assume that they have > > an ECA on file: https://api.eclipse.org/bots > > This is based on an assumption that bots are not adding intellectual > property. That is, anything that a bot may contribute is expected to be > either configuration or content generated from intellectual property that is > already available to the project. > > +1 Sounds good! This is still an API side change, and I'm hoping to have the changes + tests done in the next 2 hours and up for review. This will be a transparent update to the plugin since those PR's will just be approved after this point
Hi, I don't know if the issue I'm facing is related to the upgrade, but I have trouble pushing a patch to gerrit today. Here's the output I get when pushing: remote: commit 0fd163b: Authored by: Geneviève Bastien <gbastien+lttng@versatic.net> remote: commit 0fd163b: Could not find an Eclipse user with mail 'gbastien+lttng@versatic.net' for author of commit 0fd163be4b233dc9e5e096cafcea52e581651448 remote: commit 0fd163b: remote: commit 0fd163b: Please see http://wiki.eclipse.org/ECA To ssh://git.eclipse.org:29418/tracecompass/org.eclipse.tracecompass.git ! [remote rejected] HEAD -> refs/for/master (commit 0fd163b: Author must have an Eclipse Account) Of course, I have an valid ECA signed until march 2022. Thanks!
(In reply to Genevieve Bastien from comment #13) > Hi, > > I don't know if the issue I'm facing is related to the upgrade, but I have > trouble pushing a patch to gerrit today. Here's the output I get when > pushing: > > remote: commit 0fd163b: Authored by: Geneviève Bastien > <gbastien+lttng@versatic.net> > remote: commit 0fd163b: Could not find an Eclipse user with mail > 'gbastien+lttng@versatic.net' for author of commit > 0fd163be4b233dc9e5e096cafcea52e581651448 > remote: commit 0fd163b: > remote: commit 0fd163b: Please see http://wiki.eclipse.org/ECA > To ssh://git.eclipse.org:29418/tracecompass/org.eclipse.tracecompass.git > ! [remote rejected] HEAD -> refs/for/master (commit 0fd163b: Author > must have an Eclipse Account) > > Of course, I have an valid ECA signed until march 2022. > > Thanks! This seems to be due to the upgrade, but not due to any issue with the plugin itself, but rather some of our underlying services not handling your registered email as expected. We've looked into this, and implemented fixes on our end, with the API fix being up for review and should be up soon if all goes well! Thanks for the report!
(In reply to Genevieve Bastien from comment #13) > Hi, > > I don't know if the issue I'm facing is related to the upgrade, but I have > trouble pushing a patch to gerrit today. Here's the output I get when > pushing: > > remote: commit 0fd163b: Authored by: Geneviève Bastien > <gbastien+lttng@versatic.net> > remote: commit 0fd163b: Could not find an Eclipse user with mail > 'gbastien+lttng@versatic.net' for author of commit > 0fd163be4b233dc9e5e096cafcea52e581651448 > remote: commit 0fd163b: > remote: commit 0fd163b: Please see http://wiki.eclipse.org/ECA > To ssh://git.eclipse.org:29418/tracecompass/org.eclipse.tracecompass.git > ! [remote rejected] HEAD -> refs/for/master (commit 0fd163b: Author > must have an Eclipse Account) > > Of course, I have an valid ECA signed until march 2022. > > Thanks! Could you try again now? The fix for our service is up, so you should be able to commit just fine now!
It works well, thanks!
(In reply to Martin Lowe from comment #15) > (In reply to Genevieve Bastien from comment #13) > > Hi, > > > > I don't know if the issue I'm facing is related to the upgrade, but I have > > trouble pushing a patch to gerrit today. Here's the output I get when > > pushing: > > > > remote: commit 0fd163b: Authored by: Geneviève Bastien > > <gbastien+lttng@versatic.net> > > remote: commit 0fd163b: Could not find an Eclipse user with mail > > 'gbastien+lttng@versatic.net' for author of commit > > 0fd163be4b233dc9e5e096cafcea52e581651448 > > remote: commit 0fd163b: > > remote: commit 0fd163b: Please see http://wiki.eclipse.org/ECA > > To ssh://git.eclipse.org:29418/tracecompass/org.eclipse.tracecompass.git > > ! [remote rejected] HEAD -> refs/for/master (commit 0fd163b: Author > > must have an Eclipse Account) > > > > Of course, I have an valid ECA signed until march 2022. > > > > Thanks! > > Could you try again now? The fix for our service is up, so you should be > able to commit just fine now! The Hono website build is still not working with the same problem [1] [1] https://ci.eclipse.org/hono/job/Hono-Website-Declarative-Pipeline/79/console
The website build job of the IoT Packages project is also broken [1] Since the website is our primary means of distributing the Helm charts for the Eclipse IoT projects, this is really starting to affect our ability to deliver updates ... [1] https://ci.eclipse.org/packages/job/Website/job/master/81/console
(In reply to Kai Hudalla from comment #18) > The website build job of the IoT Packages project is also broken [1] > > Since the website is our primary means of distributing the Helm charts for > the Eclipse IoT projects, this is really starting to affect our ability to > deliver updates ... > > > [1] https://ci.eclipse.org/packages/job/Website/job/master/81/console @Kai We were waiting for a code review on something, but it has been pushed live now! See Wayne and Chris' comments on what's changed, but your bot builds should pass now!
(In reply to Martin Lowe from comment #19) > (In reply to Kai Hudalla from comment #18) > > The website build job of the IoT Packages project is also broken [1] > > > > Since the website is our primary means of distributing the Helm charts for > > the Eclipse IoT projects, this is really starting to affect our ability to > > deliver updates ... > > > > > > [1] https://ci.eclipse.org/packages/job/Website/job/master/81/console > > @Kai > > We were waiting for a code review on something, but it has been pushed live > now! See Wayne and Chris' comments on what's changed, but your bot builds > should pass now! They indeed both do. Thanks for fixing it :-) Kai
(I initially reported this on https://github.com/EclipseFdn/gerrit-eca-plugin/issues/30): The recently updated change pushed out is causing problems - see my email on cross-project[1]. On issue 30 it was reported that this is expected behaviour. If so, please change the wording I have already had one person reach out to me privately asking what happened to their committer status. [1] https://www.eclipse.org/lists/cross-project-issues-dev/msg18095.html
(In reply to Jonah Graham from comment #21) > (I initially reported this on > https://github.com/EclipseFdn/gerrit-eca-plugin/issues/30): > > The recently updated change pushed out is causing problems - see my email on > cross-project[1]. On issue 30 it was reported that this is expected > behaviour. If so, please change the wording I have already had one person > reach out to me privately asking what happened to their committer status. > > [1] https://www.eclipse.org/lists/cross-project-issues-dev/msg18095.html I took a look and this is expected. This repo does not have an official list of committers because the ssh://git.eclipse.org:29418/simrel/org.eclipse.simrel.build repository is not owned by an Eclipse project. However, this should not impact your ability to push (write access). You will simply be required to include the sign-off-by footer in the commit message.
What about CDT's website. Same thing?
(In reply to Jonah Graham from comment #23) > What about CDT's website. Same thing? Correct! The ECA plugin is matching repos with projects via an API from the PMI. The list of repos for cdt are listed here: https://projects.eclipse.org/api/projects/tools.cdt.json Anything outside of those repos in Gerrit should require the sign-off-by footer.
(In reply to Christopher Guindon from comment #24) > (In reply to Jonah Graham from comment #23) > Anything outside of those repos in Gerrit should require the sign-off-by > footer. There are some exceptions to this rule. For example, the Signed-off-by footer is not required if you are committing code to your project website repository using an Eclipse bot: https://api.eclipse.org/bots
*** Bug 569607 has been marked as a duplicate of this bug. ***
Closing this issue! Thanks all!
