Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 568486 - [Dark theme] Remove workaround from Bug 562007
Summary: [Dark theme] Remove workaround from Bug 562007
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.17   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.18 M3   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-03 07:16 EST by Lars Vogel CLA
Modified: 2020-11-04 07:58 EST (History)
2 users (show)

See Also:

Attachments
withWithout (42.70 KB, image/png)
2020-11-04 04:25 EST, Philippe Dul CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-11-03 07:16:57 EST 
If I remove the special styling for Bug 562007 I still see consistant styling.

CTabFolder.MArea {
    swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
    padding: 0px;
    background-color: '#org-eclipse-ui-workbench-DARK_BACKGROUND'; 
    swt-selected-tab-fill: '#org-eclipse-ui-workbench-DARK_BACKGROUND'; 
    swt-unselected-tabs-color: '#org-eclipse-ui-workbench-DARK_BACKGROUND'; 
    swt-outer-keyline-color: '#org-eclipse-ui-workbench-DARK_BACKGROUND'; 
    swt-inner-keyline-color: '#org-eclipse-ui-workbench-DARK_BACKGROUND'; 
    swt-tab-outline: '#org-eclipse-ui-workbench-DARK_BACKGROUND'; 
}
Comment 1 Lars Vogel CLA 2020-11-03 07:22:05 EST 
Philippe, can you still reproduce with the additional CSS?
Comment 2 Eclipse Genie CLA 2020-11-03 07:25:46 EST 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/171677
Comment 3 Philippe Dul CLA 2020-11-04 04:25:51 EST 
Created attachment 284665 [details]
withWithout

Hi, 

I've tested your patch with 2020-09R. (withWithout.png)
Indeed the black padding fixed by 562007 seems to be fixed with another issue and can be removed here.

In your patch, if you also remove the changes on colors, we see that there is a slight difference (withWithout.png) (ie with your match, and without your patch)

idk which one looks better.
Comment 4 Lars Vogel CLA 2020-11-04 04:33:50 EST 
(In reply to Philippe Dul from comment #3)
> Created attachment 284665 [details]
> withWithout
> 
> Hi, 
> 
> I've tested your patch with 2020-09R. (withWithout.png)
> Indeed the black padding fixed by 562007 seems to be fixed with another
> issue and can be removed here.
> 
> In your patch, if you also remove the changes on colors, we see that there
> is a slight difference (withWithout.png) (ie with your match, and without
> your patch)
> 
> idk which one looks better.

Me neither. :-) Lets merge it and if we think we other looks better, change the CTabFolder styling in general. Less CSS rules is better IMHO.