Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 56839 - [Icons] Icons for File-Import and File-Export seem the wrong way around
Summary: [Icons] Icons for File-Import and File-Export seem the wrong way around
Status: VERIFIED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Chris McLaren CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 53617
  Show dependency tree
 
Reported: 2004-03-30 17:36 EST by Alex Blewitt CLA
Modified: 2004-07-01 02:14 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2004-03-30 17:36:07 EST
I just noticed the change in the import and export icons, and it seems to me that the import and export 
icons are the wrong way around. I'd always assumed that the import icon has the small blue triangle on 
the left, pointing towards the window icon, whereas the export icon would have the small blue triangle 
on the right, pointing away from the window icon. I guess that that's what it used to look like in WSAD, 
but I've not worked with that recently enough to remember.

In any case, the icons have changed a little in 3.0M8 and it now seems that the icons have been 
reversed; the export is on the left pointing towards the window, whilst the import is on the right 
pointing away from the window. Is this a minor glitch in the names for the icon files?

Eclipse 3.0M8 on Mac OS X.3.3
Comment 1 Andre Weinand CLA 2004-03-31 03:57:54 EST
Yes, I don't understand these icons either:
If my assumption is correct that the little window represents Eclipse,
then they are definitely swapped.
But if the window represents something outside of Eclipse then the arrows
are correct, but then the meaning of the icons is very hard to grasp...
Comment 2 Alex Blewitt CLA 2004-03-31 04:28:29 EST
I'd also like it if the icons had the window centralised: the position of the window seems to be shifted 
slightly with the new look.

Something like:

.    +--+
.    |  |
.  > +--+

and
.    +--+
.    |  |
.    +--+ >

rather than

.    +--+
.    |  |
.  > +--+

and

.  +--+
.  |  |
.  +--+ >

Please excuse the ASCII art, and I hope that the example works :-)
Comment 3 Alex Blewitt CLA 2004-03-31 04:30:03 EST
Aha, it did work :-)

Dots are just there so that leading spaces weren't eaten.
Comment 4 Andre Weinand CLA 2004-04-12 10:09:05 EDT
[set OS and platforms to "All" since this problem isn't Mac specific]
Comment 5 Markus Keller CLA 2004-06-10 12:15:28 EDT
+1 for Randy Hudson's bug 66159 comment 2:

> The icon clearly has a titlebar and menubar, which suggests that it is the 
> workbench window.  If you want it to be a generic file type icon, make it look 
> like a document, not a window.  For example, the icon used for unknown types
> in the navigator view.



Comment 6 Randy Hudson CLA 2004-06-11 14:44:07 EDT
Given that this icon is going to be copied 100 times, can we get it right for 
3.0?
Comment 7 Michael Van Meekeren CLA 2004-06-24 10:38:14 EDT
fixed.
Comment 8 Alex Blewitt CLA 2004-06-30 09:05:02 EDT
This bug didn't get completely quashed. Although the 'Import' and 'Export' icons from the 'file' menu 
have been correctly fixed, the 'File -- Import' Wizard and 'File -- Export' Wizard are still as shown in the 
ASCII diagram in #2 

It looks like the icon used for the label decorators are applied to the wrong wizard.
Comment 9 Alex Blewitt CLA 2004-06-30 09:05:32 EDT
Oops, should have said Eclipse 3.0 (25 June) on Mac OS X.3.4
Comment 10 Tod Creasey CLA 2004-06-30 09:49:30 EDT
We won't be doing anything else on these icons in the forseeable future.
Comment 11 Alex Blewitt CLA 2004-06-30 09:56:05 EDT
So why not leave it open? Why say 'wontfix', which is an adamant statement that it will never be fixed? 
The fact that the bug exists, but that it won't be considered at this time, suggests that it should either 
be left as open, or mark as later.

Comment 12 Markus Keller CLA 2004-06-30 10:11:14 EDT
Alex, I don't see what's wrong with the icons in 3.0.
Could you please explain what you think is wrong, and for which icons exactly?
Comment 13 Alex Blewitt CLA 2004-06-30 10:34:08 EDT
I tried to show it in the ASCII art in comment #2, but obviously it wasn't that good :-)

If you open Eclipse, and select the File -> Import menu, you get prompted with a list of choices, such 
as:

o Checkout Projects from CVS
o Existing Ant Buildfile
o Existing Project into Workspace
o External Features
o External Plugins and Fragments
o File System
o Team Project Set
o Zip File

For the options 'External Features' through 'Zip File', the icon has a label decorator in the bottom right 
(bottom left for the 'Export' dialog). This arrow seems to point down and to the right for the import 
options; I would have thought an arrow pointing to the icon would have made more sense for 
importing.

For the export options, the same is true in reverse; the label decorator icon is at the bottom left, and 
appears to point in to the icon. I had always assumed (and hence filed this bug) on the assumption that 
something pointing into the centre of the icon would be an import in to Eclipse, and the arrow pointing 
away from the icon would be for an export from Eclipse -- but the icons are the opposite of this 
assumption.

So my proposal would be to swap the blue triangle label decorators for the 'import' and 'export' dialogs, 
so that the import is at the bottom left and points in, whereas the export is at the bottom right and 
points out.
Comment 14 Markus Keller CLA 2004-06-30 11:03:11 EDT
OK then, what I read out of comment 2 was that the icons were (not) properly
centered, but that doesn't seem to be the problem.

However, I don't share your opinion that the arrows for the individual
import/export kinds point into the wrong direction. Please read MVM's
explanation in bug 66159 comment 1 to see why it must be this way.

Let's open the Import wizard and look at the "Zip file" icon. The arrow points
from the Zip file to the lower right (where you can imagine the workspace into
which the contents will be imported). This is consistent with the big wizard
banner in the upper right of the dialog, where the arrow points to the workspace
(but the arrow's origin is not part of the generic icon/banner since it is
different for each kind of import).

Summarizing, the generic import icon shows the arrow pointing to the workspace,
while the individual import kind icons show an arrow originating in an image of
what they import.

For me, this bug is not a WONTFIX, but a plain FIXED.
Comment 15 Alex Blewitt CLA 2004-07-01 02:14:01 EDT
Although I do not believe the icons are naturally intuitive, I understand the reason and agree that this is 
consistent with the other icons, so verifiying.