Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 568290 - Leak tests failing with JDK 16
Summary: Leak tests failing with JDK 16
Status: RESOLVED WORKSFORME
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.18   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: BETA J16   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 567180 568025
  Show dependency tree
 
Reported: 2020-10-27 03:28 EDT by Sarika Sinha CLA
Modified: 2020-10-27 05:11 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sarika Sinha CLA 2020-10-27 03:28:48 EDT 
Leak tests might fail with Java 16.

Do we need them now as tests are not running for Java 8.
Comment 1 Noopur Gupta CLA 2020-10-27 04:21:36 EDT 
(In reply to Sarika Sinha from comment #0)
> Leak tests might fail with Java 16.

 
> Do we need them now as tests are not running for Java 8.

Asking about the tests if we need them?
Comment 2 Sarika Sinha CLA 2020-10-27 04:57:28 EDT 
(In reply to Noopur Gupta from comment #1)
> (In reply to Sarika Sinha from comment #0)
> > Leak tests might fail with Java 16.
> 
>  
> > Do we need them now as tests are not running for Java 8.
> 
> Asking about the tests if we need them?

Yes.
Comment 3 Noopur Gupta CLA 2020-10-27 05:07:25 EDT 
(In reply to Sarika Sinha from comment #2)
> (In reply to Noopur Gupta from comment #1)
> > (In reply to Sarika Sinha from comment #0)
> > > Leak tests might fail with Java 16.
> > 
> >  
> > > Do we need them now as tests are not running for Java 8.
> > 
> > Asking about the tests if we need them?
> 
> Yes.

These tests don't test any Java version-specific functionality. They are for Java text editors. So we still need them.
Comment 4 Noopur Gupta CLA 2020-10-27 05:11:50 EDT 
This time the tests may not fail with JDK 16 unless a new --add-opens is required similar to bug 567682 as the XML already mentions <javaversion atleast="9"/>.

We can reopen the bug if it is failing.