Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 565846 - [15] Syntax coloring for permits
Summary: [15] Syntax coloring for permits
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.17   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: BETA J15   Edit
Assignee: Kalyan Prasad Tatavarthi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 565850
Blocks: 561403
  Show dependency tree
 
Reported: 2020-08-06 02:51 EDT by Vikas Chandra CLA
Modified: 2020-09-08 05:47 EDT (History)
2 users (show)

See Also:

Attachments
see image (8.89 KB, image/png)
2020-08-06 02:51 EDT, Vikas Chandra CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vikas Chandra CLA 2020-08-06 02:51:56 EDT 
Created attachment 283803 [details]
see image

Version: 2020-09 (4.17)
Build id: Y20200805-1200

sealed etc are colored but permits is not coloured.
Comment 1 Noopur Gupta CLA 2020-08-06 03:08:53 EDT 
Need to add support for coloring "permits".
Comment 2 Eclipse Genie CLA 2020-08-06 12:26:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/167363
Comment 4 Eclipse Genie CLA 2020-08-12 02:57:07 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/167572
Comment 6 Noopur Gupta CLA 2020-08-12 03:08:09 EDT 
Kalyan, I see that you have used the constants, messages etc. created for "record" in case of "permits" also. It is confusing that record settings are being used to control permits in the code.

It will be good to update the names, msg text, Javadoc etc. for the reusable stuff to something generic so that we will be able to resuse them for such keywords in the future also.
Comment 7 Noopur Gupta CLA 2020-09-08 05:47:46 EDT 
(In reply to Noopur Gupta from comment #6)
> Kalyan, I see that you have used the constants, messages etc. created for
> "record" in case of "permits" also. It is confusing that record settings are
> being used to control permits in the code.
> 
> It will be good to update the names, msg text, Javadoc etc. for the reusable
> stuff to something generic so that we will be able to resuse them for such
> keywords in the future also.

Moved this to bug 566771.