Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 565186 - Download file management: Profile info does not work
Summary: Download file management: Profile info does not work
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Website (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: phoenix.ui CLA
QA Contact:
URL: https://download.eclipse.org/kitalpha/
Whiteboard:
Keywords:
: 571594 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-07-13 13:03 EDT by Denis Roy CLA
Modified: 2021-11-04 13:44 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Roy CLA 2020-07-13 13:03:48 EDT 
If you're logged into eclipse.org, the login state is not reflected correctly on download.e.o and archive.e.o, leading you to believe you're not logged in.  See upper right-hand corner of https://download.eclipse.org/kitalpha/ as an example.
Comment 1 Christopher Guindon CLA 2020-07-13 13:10:28 EDT 
Denis,

Can you confirm that these pages are running the latest version of eclipse.org-common and that they can successfully connect to the session table in the Eclipse database?
Comment 2 Denis Roy CLA 2020-07-13 13:13:19 EDT 
They have the latest e.o-c and can (likely) connect.

They are not set up for it.  The 404.php handler includes a static 404.html page with "Log in" hardcoded.

Since download.e.o handles about 13M 404's per day, we'll need to be delicate while fixing this (ie, only load the session if ECLIPSESESSION cookie is present, otherwise, keep using the static file)
Comment 3 Christopher Guindon CLA 2020-07-13 13:26:16 EDT 
(In reply to Denis Roy from comment #2)
> They have the latest e.o-c and can (likely) connect.
> 
> They are not set up for it.  The 404.php handler includes a static 404.html
> page with "Log in" hardcoded.
> 
> Since download.e.o handles about 13M 404's per day, we'll need to be
> delicate while fixing this (ie, only load the session if ECLIPSESESSION
> cookie is present, otherwise, keep using the static file)

Gotcha! I see what you mean here:
https://git.eclipse.org/c/www.eclipse.org/errors.git/tree/download.eclipse.org/404.php#n53

(In reply to Denis Roy from comment #2)
> Since download.e.o handles about 13M 404's per day, we'll need to be
> delicate while fixing this (ie, only load the session if ECLIPSESESSION
> cookie is present, otherwise, keep using the static file)

I will need to verify but I would expect this behavior to already exist.

We shouldn't try to load an ECLIPSESSION on any of our pages if we can't fetch a value from the ECLIPSESESSION cookie.

I will also verify what other db calls we are making when generating the template.
Comment 4 Denis Roy CLA 2021-06-10 09:55:55 EDT 
*** Bug 571594 has been marked as a duplicate of this bug. ***
Comment 5 Eclipse Genie CLA 2021-11-03 14:23:22 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/errors/+/187281
Comment 7 Denis Roy CLA 2021-11-04 13:44:11 EDT 
This is now live.