Community
Participate
Working Groups
I noticed some minor issues in my recently added JUnit tests. OutputStreamMonitorTests Two of the tests are explicit written for UTF-8 but the monitor is initialized with default charset. Since many modern systems use UTF-8 as default the test still works most of the times. InputStreamMonitorTests The closing test stops the input monitoring thread and immediately checks if the thread is stopped. I saw a few random test failures locally from this race condition. BreakpointTests Calling dispose on a view is not the right way to close the view. I admit this one was a bit stupid.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/165705
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/165705 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=df9297cf8536bdaa582eed3649065e2323ea791e
We still see one failure. https://download.eclipse.org/eclipse/downloads/drops4/I20200703-1800/testresults/html/org.eclipse.debug.tests_ep417I-unit-win32-java11_win32.win32.x86_64_11.html testBug424561_undoRedoUndoGone Failure Breakpoint is not deleted java.lang.AssertionError: Breakpoint is not deleted at org.junit.Assert.fail(Assert.java:89) at org.eclipse.debug.tests.TestUtil.waitWhile(TestUtil.java:134) at org.eclipse.debug.tests.breakpoint.BreakpointTests.testBug424561_undoRedoUndoGone(BreakpointTests.java:110) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
Did not failed with I20200704-0600. But testRedirectOutputToFile Failure Output not found in console. expected:<[Hello World!]> but was:<[]> org.junit.ComparisonFailure: Output not found in console. expected:<[Hello World!]> but was:<[]> at org.junit.Assert.assertEquals(Assert.java:117) at org.eclipse.debug.tests.console.ProcessConsoleTests.doConsoleOutputTest(ProcessConsoleTests.java:400) at org.eclipse.debug.tests.console.ProcessConsoleTests.testRedirectOutputToFile(ProcessConsoleTests.java:302) Will see if I can find the reason for the instability of both...
Yes, again in 5th build: https://download.eclipse.org/eclipse/downloads/drops4/I20200705-0710/testresults/html/org.eclipse.debug.tests_ep417I-unit-win32-java11_win32.win32.x86_64_11.html
Not seeing any failure in recent builds.
We have failure today https://download.eclipse.org/eclipse/downloads/drops4/I20200813-1800/testresults/html/org.eclipse.debug.tests_ep417I-unit-cen64-gtk3-java11_linux.gtk.x86_64_11.html https://download.eclipse.org/eclipse/downloads/drops4/I20200813-1800/testresults/html/org.eclipse.debug.tests_ep417I-unit-cen64-gtk3-java14_linux.gtk.x86_64_14.html testNullCharset Failure Monitor read wrong content. expected:<o[öOïiIÖØø]> but was:<o[?O?iI???]> org.junit.ComparisonFailure: Monitor read wrong content. expected:<o[öOïiIÖØø]> but was:<o[?O?iI???]> at org.junit.Assert.assertEquals(Assert.java:117) at org.eclipse.debug.tests.console.OutputStreamMonitorTests.testNullCharset(OutputStreamMonitorTests.java:181) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) testNullCharset Failure Monitor wrote wrong content. expected:<o[öOïiIÖØø]> but was:<o[?O?iI???]> org.junit.ComparisonFailure: Monitor wrote wrong content. expected:<o[öOïiIÖØø]> but was:<o[?O?iI???]> at org.junit.Assert.assertEquals(Assert.java:117) at org.eclipse.debug.tests.console.InputStreamMonitorTests.testNullCharset(InputStreamMonitorTests.java:87)
It is consistently failing since last few days. @Paul, Can you look into this? https://download.eclipse.org/eclipse/downloads/drops4/I20200816-0600/testresults/html/org.eclipse.debug.tests_ep417I-unit-cen64-gtk3-java11_linux.gtk.x86_64_11.html
Did not see it happen in 4.18 timeframe.
