Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 564818 - [Passage] API revision | conditions | key keepers review
Summary: [Passage] API revision | conditions | key keepers review
Status: CLOSED FIXED
Alias: None
Product: Passage
Classification: Technology
Component: API (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.0.0   Edit
Assignee: Elena Parovyshnaia CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 564419
  Show dependency tree
 
Reported: 2020-07-01 04:01 EDT by Elena Parovyshnaia CLA
Modified: 2020-07-05 07:04 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elena Parovyshnaia CLA 2020-07-01 04:01:50 EDT 
In the scope of general API revision KeyKeeper-related interface and implementation are to be also questioned against new API approach guides, revised and, most probably, reimplemented. 

As the result
  - new interfaces and implementation must appear complying with the new API approach. Functionality must be kept.
  - old ones are to be deprecated
  - tests should appear where possible
Comment 1 Elena Parovyshnaia CLA 2020-07-04 13:51:53 EDT 
PR#1 https://github.com/eclipse-passage/passage/pull/281
  - new versions of KeyKeeper and  `KeyKeeperRegistry` are designed in `lic.api` / `internal.api.io`
  - current ones are deprecated

PR#2 https://github.com/eclipse-passage/passage/pull/282
   - reimplement `BundleKeykeeper` over the new (1.0) interfaces
   - deprecate obsolete implementation
   - test new `BundleKeykeeper`
   - plug BundleKeyKeeper service to the sealed framework
Comment 2 Elena Parovyshnaia CLA 2020-07-05 07:04:44 EDT 
`lic.api` / 'lic.internal.api.io` - new interfaces for `KeyKeeper` and registry

`lic.equinox` / `lic.internal.equinox.io` - reimplemented `BundleKeyKeeper
`
`lic.equinox.tests` / `lic.internal.equinox.io` - test set for `BundleKeyKeeper`