Community
Participate
Working Groups
1. Click on Search->Java 2.In "Limit to" section, click on "0 of 15 selected" 3. Match location selection dialog comes up It should have a checkbox for permit types with when selected should search for permit types.
@Noopur: With the latest changes in spec, the permitted types are now referred to as "Permitted Direct Subclasses" - so it maybe appropriate to have the ui text reflecting the above for now (or until the next preview if it changes).
(In reply to Manoj Palat from comment #1) > "Permitted Direct Subclasses" We can have permitted records and interfaces also. Is the spec still going to use the term "subclasses"? I was planning to use "Permitted type declarations" similar to the existing option of "Super type declarations". If "direct" needs to be added, we can have it as "Permitted direct type declarations".
Or, "Permitted direct subtype declarations".
Can you specify if the API in bug 564049 searches only for the directly permitted subtypes or the indirect ones as well?
(In reply to Noopur Gupta from comment #4) > Can you specify if the API in bug 564049 searches only for the directly > permitted subtypes or the indirect ones as well? All the permit types present in typeDecl.permittedTypes. @Manoj does typeDecl.permittedTypes contain direct types or both indirect/direct types.
(In reply to Noopur Gupta from comment #2) > (In reply to Manoj Palat from comment #1) > > "Permitted Direct Subclasses" > > We can have permitted records and interfaces also. Is the spec still going > to use the term "subclasses"? Yes, we can have interfaces also; No, We cannot have records. > I was planning to use "Permitted type declarations" similar to the existing > option of "Super type declarations". Maybe at this point, you can leave it as it is. The bug 564558 addresses the new terminology adjustment in core. Once we start on that we can have a corresponding ui bug to finalize the terms in tandem.
(In reply to Vikas Chandra from comment #5) > @Manoj does typeDecl.permittedTypes contain direct types or both > indirect/direct types. permitted clause deals with only one level and hence all the types will be direct.
It's still not clear from the previous comments why "direct", "sub" and "classes" words should be used in the display text. I will go ahead with "Permitted type declarations" as planned earlier. Please open a new bug in UI with the proposed text when the terminology adjustments are finalized in Core.
(In reply to Noopur Gupta from comment #8) > > Please open a new bug in UI with the proposed text when the terminology > adjustments are finalized in Core. With you on that as mentioned in comment 6 - "we can have a corresponding ui bug to finalize the terms in tandem"
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166492
(In reply to Eclipse Genie from comment #10) > New Gerrit change created: > https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166492 Build proceeded after a new Y-build. Test failures are not related and are due to bug 565192.
Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166492 was merged to [BETA_JAVA15]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=032ad1d39cdf54ef06cb8f09f996c0c763e15c2a
While testing for java search and content assist in the new Y build, I found and fixed Bug 565653.
(In reply to Vikas Chandra from comment #13) > While testing for java search and content assist in the new Y build, I found > and fixed Bug 565653. Thanks, Vikas.
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/170503
Gerrit change https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/170503 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=e7e917189fe509be90c2f19efb38257683b21bc5
