Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 563586 - [15] Create icons for Sealed and Non-Sealed Types
Summary: [15] Create icons for Sealed and Non-Sealed Types
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.16   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: BETA J15   Edit
Assignee: Kalyan Prasad Tatavarthi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 561403 564895
  Show dependency tree
 
Reported: 2020-05-26 08:50 EDT by Kalyan Prasad Tatavarthi CLA
Modified: 2020-07-03 04:31 EDT (History)
5 users (show)

See Also:

Attachments
Display sample (207.01 KB, image/jpeg)
2020-06-16 07:51 EDT, Kalyan Prasad Tatavarthi CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kalyan Prasad Tatavarthi CLA 2020-05-26 08:50:40 EDT 
Icons for Sealed Types need to be created to be shown in project explorer etc.
Comment 1 Eclipse Genie CLA 2020-06-16 07:45:35 EDT 
New Gerrit change created: https://git.eclipse.org/r/164984
Comment 2 Eclipse Genie CLA 2020-06-16 07:46:17 EDT 
New Gerrit change created: https://git.eclipse.org/r/164985
Comment 3 Kalyan Prasad Tatavarthi CLA 2020-06-16 07:51:22 EDT 
Created attachment 283298 [details]
Display sample

This attachment shows how the sealed and non-sealed keywords will be shown as icons on Class and Interface in Project Explorer as well as in the outline view in both light and dark modes.
Comment 4 Manoj N Palat CLA 2020-06-17 05:16:59 EDT 
(In reply to Kalyan Prasad Tatavarthi from comment #3)
> Created attachment 283298 [details]
> Display sample
> 
> This attachment shows how the sealed and non-sealed keywords will be shown
> as icons on Class and Interface in Project Explorer as well as in the
> outline view in both light and dark modes.

@Kalyan: These look fine - one comment though - For non-sealed, I see a square in dark theme and a circle in light theme -expected these to be similar irrespective of themes - just an observation
Comment 5 Kalyan Prasad Tatavarthi CLA 2020-06-17 05:21:40 EDT 
(In reply to Manoj Palat from comment #4)
> (In reply to Kalyan Prasad Tatavarthi from comment #3)
> > Created attachment 283298 [details]
> > Display sample
> > 
> > This attachment shows how the sealed and non-sealed keywords will be shown
> > as icons on Class and Interface in Project Explorer as well as in the
> > outline view in both light and dark modes.
> 
> @Kalyan: These look fine - one comment though - For non-sealed, I see a
> square in dark theme and a circle in light theme -expected these to be
> similar irrespective of themes - just an observation

The background for these icons is a square which is white in color. In light theme this blends with the background.If you look  at the icons in Package Explorer, the icon is a square.
Comment 8 Jay Arthanareeswaran CLA 2020-06-17 08:37:16 EDT 
Hope my comments are not too late. But I was wondering if it would make sense to depict the idea of sealed pictorially rather than going with 's'. You know, just in case, they go with a different keyword? Unlike records, it may be relatively easier to capture the concept of sealed types.
Comment 9 Sarika Sinha CLA 2020-06-17 10:12:13 EDT 
(In reply to Jay Arthanareeswaran from comment #8)
> Hope my comments are not too late. But I was wondering if it would make
> sense to depict the idea of sealed pictorially rather than going with 's'.
> You know, just in case, they go with a different keyword? Unlike records, it
> may be relatively easier to capture the concept of sealed types.

Any suggestions to depict it Jay?