Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 563277 - Unify trim bar handles
Summary: Unify trim bar handles
Status: CLOSED DUPLICATE of bug 563497
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.16   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.20 M1   Edit
Assignee: Matthias Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-18 04:27 EDT by Matthias Becker CLA
Modified: 2021-03-24 03:22 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Becker CLA 2020-05-18 04:27:18 EDT 
As discussed in https://bugs.eclipse.org/bugs/show_bug.cgi?id=563079#c25 we should unify the trim bar handles and the trim bar frames.
Comment 1 Matthias Becker CLA 2020-05-18 04:29:19 EDT 
We can remove the rounded corners of the frame or we could get rid of the frame completely (as we already do in the dark theme).

What do yo think?
Comment 2 Lars Vogel CLA 2020-05-18 04:38:59 EDT 
+1 for removal
Comment 3 Lars Vogel CLA 2020-06-03 05:57:22 EDT 
(In reply to Lars Vogel from comment #2)
> +1 for removal

Should we still align the images in the code base?
Comment 4 Andrew Obuchowicz CLA 2020-06-03 09:37:35 EDT 
(In reply to Lars Vogel from comment #3)
> (In reply to Lars Vogel from comment #2)
> > +1 for removal
> 
> Should we still align the images in the code base?

I would say yes, assuming that using the same image for all themes looks OK.
Comment 5 Lars Vogel CLA 2020-06-22 06:05:42 EDT 
Matthias, can you provide Gerrit?
Comment 6 Dani Megert CLA 2020-07-13 04:38:34 EDT 
Please remove the target milestone if you don't plan to fix during 4.17.
Comment 7 Kalyan Prasad Tatavarthi CLA 2021-03-02 02:02:22 EST 
Mass move to 4.20
Comment 8 Matthias Becker CLA 2021-03-24 03:22:50 EDT 
The frames have been removed with Bug 563497

*** This bug has been marked as a duplicate of bug 563497 ***