Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 563160 - Remove background color from help toobar to look good in light and dark theme to look good in dark and light theme
Summary: Remove background color from help toobar to look good in light and dark theme...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 4.14   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.16 RC1   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 560385
  Show dependency tree
 
Reported: 2020-05-14 05:11 EDT by Lars Vogel CLA
Modified: 2020-05-22 08:08 EDT (History)
4 users (show)

See Also:

Attachments
Screenshot (16.05 KB, image/png)
2020-05-14 05:11 EDT, Lars Vogel CLA 		no flags Details
Currently light look of help toolbar (2.80 KB, image/png)
2020-05-19 09:15 EDT, Lars Vogel CLA 		no flags Details
Light theme with patch (2.83 KB, image/png)
2020-05-19 09:18 EDT, Lars Vogel CLA 		no flags Details
Dark theme with patch (2.98 KB, image/png)
2020-05-19 09:18 EDT, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-05-14 05:11:56 EDT 
Created attachment 282839 [details]
Screenshot

The current help toolbar looks bad on the dark theme with its blueisch background, see screenshot.
Comment 1 Andrew Obuchowicz CLA 2020-05-14 06:23:39 EDT 
+1 this has bothered me in the past
Comment 2 Lars Vogel CLA 2020-05-19 09:15:30 EDT 
Created attachment 282929 [details]
Currently light look of help toolbar
Comment 3 Lars Vogel CLA 2020-05-19 09:18:29 EDT 
Created attachment 282930 [details]
Light theme with patch
Comment 4 Lars Vogel CLA 2020-05-19 09:18:47 EDT 
Created attachment 282931 [details]
Dark theme with patch
Comment 5 Eclipse Genie CLA 2020-05-19 09:19:20 EDT 
New Gerrit change created: https://git.eclipse.org/r/163233
Comment 6 Matthias Becker CLA 2020-05-19 09:28:11 EDT 
(In reply to Lars Vogel from comment #3)
> Created attachment 282930 [details]
> Light theme with patch

But now also the frame is gone?
Comment 7 Lars Vogel CLA 2020-05-19 09:31:29 EDT 
(In reply to Matthias Becker from comment #6)
> But now also the frame is gone?

Yes, I like it without the custom drawing. WDYT?
Comment 8 Matthias Becker CLA 2020-05-19 10:42:12 EDT 
(In reply to Lars Vogel from comment #7)
> (In reply to Matthias Becker from comment #6)
> > But now also the frame is gone?
> 
> Yes, I like it without the custom drawing. WDYT?

But this bug is about removing the background. 
Shouldn't we move removing the frame out into another bug?
Comment 9 Lars Vogel CLA 2020-05-19 10:58:51 EDT 
(In reply to Matthias Becker from comment #8)

> But this bug is about removing the background.

 Its my bug, so I retarged it. :-) When I opened it, I did not notice the frame.