563006 – CDB settings provider/parser doesn't support "arguments" from the json

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 563006 - CDB settings provider/parser doesn't support "arguments" from the json

Summary: CDB settings provider/parser doesn't support "arguments" from the json

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-build-managed (show other bugs)
Version:	Next
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	10.0.0
Assignee:	Marc-André Laperle
QA Contact:	Jonah Graham

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2020-05-10 01:03 EDT by Marc-André Laperle
Modified:	2020-07-11 18:43 EDT (History)
CC List:	2 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marc-André Laperle

2020-05-10 01:03:10 EDT

Quoting https://clang.llvm.org/docs/JSONCompilationDatabase.html
"
command: The compile command executed. ...
arguments: The compile command executed as list of strings. Either arguments or command is required.
"

CMake generates "command" (at least I have seen so far!) but other tools like Fastbuild generate "arguments".

This bug is specifically for the CDB Parser Language settings provider. Other spots in CDT might need similar modifications if support for more than CMake is needed.

Comment 1 Eclipse Genie

2020-07-11 17:29:48 EDT

Gerrit change https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/162768 was merged to [master].
Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=d017917f3584c4bdc06f77a58159918124b0a2c2

Comment 2 Marc-André Laperle

2020-07-11 18:43:25 EDT

There are some flaws related to shell/environment quoting and quote escaping but the basic functionality is there and is very useful for scenarios not involving spaces and quotes.