Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 562496 - Hard to see icons for Variables view in dark theme
Summary: Hard to see icons for Variables view in dark theme
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.15   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.16 M3   Edit
Assignee: Matthias Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 560385
  Show dependency tree
 
Reported: 2020-04-26 12:41 EDT by Gayan Perera CLA
Modified: 2020-05-08 02:00 EDT (History)
3 users (show)

See Also:

Attachments
DebugVariablesView (3.96 KB, image/png)
2020-04-26 12:41 EDT, Gayan Perera CLA 		no flags Details
Icons with better contrast (37.31 KB, image/png)
2020-05-06 08:13 EDT, Matthias Becker CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gayan Perera CLA 2020-04-26 12:41:30 EDT 
Created attachment 282568 [details]
DebugVariablesView

The Variables view icon in the dark theme is hard to read.
Comment 1 Lars Vogel CLA 2020-04-27 04:45:42 EDT 
Matthias, can you help here with an icon better suited for dark and light theme?
Comment 2 Eclipse Genie CLA 2020-05-06 08:10:48 EDT 
New Gerrit change created: https://git.eclipse.org/r/162556
Comment 3 Eclipse Genie CLA 2020-05-06 08:11:30 EDT 
New Gerrit change created: https://git.eclipse.org/r/162557
Comment 4 Eclipse Genie CLA 2020-05-06 08:12:44 EDT 
New Gerrit change created: https://git.eclipse.org/r/162559
Comment 5 Eclipse Genie CLA 2020-05-06 08:13:57 EDT 
New Gerrit change created: https://git.eclipse.org/r/162560
Comment 6 Matthias Becker CLA 2020-05-06 08:13:58 EDT 
Created attachment 282726 [details]
Icons with better contrast
Comment 7 Lars Vogel CLA 2020-05-06 08:33:17 EDT 
(In reply to Matthias Becker from comment #6)
> Created attachment 282726 [details]
> Icons with better contrast

Looks definitely better. Thanks!
Comment 8 Gayan Perera CLA 2020-05-06 08:38:22 EDT 
Looks awesome :)
Comment 12 Matthias Becker CLA 2020-05-06 10:08:01 EDT 
Can somebody of the JDT committers review and merge the jdt.debug change?
Comment 13 Sarika Sinha CLA 2020-05-07 07:16:12 EDT 
(In reply to Matthias Becker from comment #12)
> Can somebody of the JDT committers review and merge the jdt.debug change?

Hi Matthias,
I tried out https://git.eclipse.org/r/#/c/162556/ in dark theme
but I could not understand the difference in image from now.

Can you please attach a screenshot as how it was looking before and how it looks now in eclipse?
Comment 14 Matthias Becker CLA 2020-05-07 07:57:15 EDT 
(In reply to Sarika Sinha from comment #13)
> (In reply to Matthias Becker from comment #12)
> > Can somebody of the JDT committers review and merge the jdt.debug change?
> 
> Hi Matthias,
> I tried out https://git.eclipse.org/r/#/c/162556/ in dark theme
> but I could not understand the difference in image from now.
> 
> Can you please attach a screenshot as how it was looking before and how it
> looks now in eclipse?

The colors of the "green bug" are lighter (especially the antennas of the bug) so this increases the contrast on dark background.
The two screenshots (attached to this bug) show the difference.
Comment 16 Sarika Sinha CLA 2020-05-07 09:06:27 EDT 
(In reply to Matthias Becker from comment #14)

> 
> The colors of the "green bug" are lighter (especially the antennas of the
> bug) so this increases the contrast on dark background.
> The two screenshots (attached to this bug) show the difference.

Thanks !