Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 562201 - [Dark Theme] Use zero left and right margins for top-level window
Summary: [Dark Theme] Use zero left and right margins for top-level window
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.14   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.16 M3   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 562200
Blocks: 560385
  Show dependency tree
 
Reported: 2020-04-16 04:55 EDT by Lars Vogel CLA
Modified: 2020-04-17 06:24 EDT (History)
5 users (show)

See Also:

Attachments
Result (267.98 KB, image/png)
2020-04-16 04:59 EDT, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-04-16 04:55:56 EDT 
I suggest to remove the margins on the top-level window.

Currently:


.MTrimmedWindow.topLevel {
	margin-top: 0px;
	margin-bottom: 0px;
	margin-left: 1px;
	margin-right: 1px;
}

Suggested:

.MTrimmedWindow {
	margin-top: 0px;
	margin-bottom: 0px;
	margin-left: 0px;
	margin-right: 0px;
}

It is only one pixel but why should use waste it?
Comment 1 Lars Vogel CLA 2020-04-16 04:57:12 EDT 
WDYT?
Comment 2 Lars Vogel CLA 2020-04-16 04:59:33 EDT 
Created attachment 282465 [details]
Result

Result looks IMHO the same but we KNOW that we have one pixel less used for margins. :-)
Comment 3 Eclipse Genie CLA 2020-04-16 05:03:55 EDT 
New Gerrit change created: https://git.eclipse.org/r/161039
Comment 4 Matthias Becker CLA 2020-04-16 06:04:41 EDT 
why not... :-)
Comment 5 Pierre-Yves Bigourdan CLA 2020-04-16 13:48:14 EDT 
Why not, indeed! :)
Comment 6 Mike Marchand CLA 2020-04-16 14:59:17 EDT 
+1 for this change, since I coincidentally just made it to our custom theme last week!
Comment 7 Lars Vogel CLA 2020-04-17 04:31:48 EDT 
Thanks for all the feedback