Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 561932 - [Dark][Mac] Toolbar items look (almost) the same when selected
Summary: [Dark][Mac] Toolbar items look (almost) the same when selected
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.16   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.16 M3   Edit
Assignee: Till Brychcy CLA
QA Contact:
URL:
Whiteboard: 4.16 M2
Keywords:
Depends on:
Blocks: 560385
  Show dependency tree
 
Reported: 2020-04-08 14:31 EDT by Till Brychcy CLA
Modified: 2020-04-30 06:28 EDT (History)
2 users (show)

See Also:

Attachments
screenshot without patch (410.78 KB, image/png)
2020-04-08 14:42 EDT, Till Brychcy CLA 		no flags Details
screenshot with patch (393.57 KB, image/png)
2020-04-08 14:42 EDT, Till Brychcy CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Till Brychcy CLA 2020-04-08 14:31:29 EDT 
In the dark design on the mac, it is very hard to see if a toolbar item is selected, especially if the background is very dark.

For example, I cannot distinguish at all if "amend commit" is selected in the git staging view.

Suggestion: If the design is dark, use a brighter rather than darker background.
Comment 1 Eclipse Genie CLA 2020-04-08 14:34:30 EDT 
New Gerrit change created: https://git.eclipse.org/r/160669
Comment 2 Till Brychcy CLA 2020-04-08 14:42:23 EDT 
Created attachment 282391 [details]
screenshot without patch
Comment 3 Till Brychcy CLA 2020-04-08 14:42:47 EDT 
Created attachment 282392 [details]
screenshot with patch
Comment 4 Till Brychcy CLA 2020-04-08 14:47:43 EDT 
@Lakshmi, do you like this solution?
Comment 5 Lakshmi P Shanmugam CLA 2020-04-09 01:49:39 EDT 
(In reply to Till Brychcy from comment #4)
> @Lakshmi, do you like this solution?

@Till, looks good! I noticed this problem too, thanks for fixing.
Comment 7 Till Brychcy CLA 2020-04-09 02:17:40 EDT 
(In reply to Eclipse Genie from comment #6)
> Gerrit change https://git.eclipse.org/r/160669 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=0b919689b3456d3dba9514a08d8e97a55f61cca2

Released for 4.16M3
Comment 8 Lakshmi P Shanmugam CLA 2020-04-09 02:23:30 EDT 

(In reply to Till Brychcy from comment #7)
> (In reply to Eclipse Genie from comment #6)
> > Gerrit change https://git.eclipse.org/r/160669 was merged to [master].
> > Commit:
> > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> > ?id=0b919689b3456d3dba9514a08d8e97a55f61cca2
> 
> Released for 4.16M3

@Till, M1 build is not done yet and this change will get picked up for M1.
Can you pls revert and merge after M1?
Comment 9 Till Brychcy CLA 2020-04-09 02:29:22 EDT 
(In reply to Lakshmi Shanmugam from comment #8)

> 
> @Till, M1 build is not done yet and this change will get picked up for M1.
> Can you pls revert and merge after M1?

Oops I'm sorry, I thought it was already out. Will revert immediately.
Comment 10 Eclipse Genie CLA 2020-04-09 02:32:46 EDT 
New Gerrit change created: https://git.eclipse.org/r/160686
Comment 12 Eclipse Genie CLA 2020-04-09 02:41:10 EDT 
New Gerrit change created: https://git.eclipse.org/r/160687
Comment 13 Lakshmi P Shanmugam CLA 2020-04-09 02:45:02 EDT 
(In reply to Till Brychcy from comment #9)
> (In reply to Lakshmi Shanmugam from comment #8)
> 
> > 
> > @Till, M1 build is not done yet and this change will get picked up for M1.
> > Can you pls revert and merge after M1?
> 
> Oops I'm sorry, I thought it was already out. Will revert immediately.

Thanks Till, M1 will be out tomorrow.
Comment 15 Till Brychcy CLA 2020-04-10 11:18:09 EDT 
(In reply to Eclipse Genie from comment #14)
> Gerrit change https://git.eclipse.org/r/160687 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=97909b409b10f9591eb267e5dbc98432cd7c688e

Released for 4.16 M3
Comment 16 Lakshmi P Shanmugam CLA 2020-04-30 06:28:00 EDT 
Verified in I20200429-1800