Community
Participate
Working Groups
As with Hight Sierra and Mojave, the bug still appear on new version of Mac OS X. It should now be fixed in this way : if version is before HighSierra do not flip the Image... to avoid to find it every year... This bug history is in bug #526091
Created attachment 281499 [details] Screenshhot
I can verify that this bug still exists on eclipse 2019-12, WB 1.9.2, MacOS 10.15.2.
Are you going to supply a patch, Olivier?
yes I am on it ... I juste installed Catalina tonight !
New Gerrit change created: https://git.eclipse.org/r/156182
That works for me.. Build is ok. But download page is still on 1.9.2. Wim are you committer to fix it and make it available using market place ? I had the same problem for the previous fixes...
See this page : https://www.eclipse.org/windowbuilder/download.php
And market place is still in 1.9.1 release... ?? I don't have the access to update it ...
(In reply to Olivier Prouvost from comment #8) > And market place is still in 1.9.1 release... ?? Version of markeplace points to latest (1.9.2). I am working on the new release. https://bugs.eclipse.org/bugs/show_bug.cgi?id=553416 > > I don't have the access to update it ... Au contraire..
(In reply to Eclipse Genie from comment #5) > New Gerrit change created: https://git.eclipse.org/r/156182 About this patch, it is going to fail again with the next OS update. I think we may now assume that they are not going to flip the screen back again. With this in mind we can make a more permanent solution. E.g. int version = Integer.newInt(OS.version.split("\\.")[0]); int mod = Integer.newInt(OS.version.split("\\.")[1]); if(version > 10 || (version == 10 && mod => 13)) flip else noflip Cheers, Wim
I agree, but I am not sure that it will not work again in the next release... It is up to you... you would prefer a solution where we check the version number after the '.' ? This is what I wanted to do (see comments), but finally I am not sure they will not change again later... Let me know
(In reply to Olivier Prouvost from comment #11) > I agree, but I am not sure that it will not work again in the next > release... > > It is up to you... you would prefer a solution where we check the version > number after the '.' ? > > This is what I wanted to do (see comments), but finally I am not sure they > will not change again later... > > Let me know Looking at the OSX history [1], I think we are safe with this approach. Of course, some protecting code would be in place. In addition, we can also supply a "flip" switch -Dwindowbuilder.osx.flip=true/false in case someone needs to make quick patch. [1] https://en.wikipedia.org/wiki/MacOS
Ok, I will fix it... Good idea for the flip switch :)
I made the change.. sounds good :)
While it is not provided on marketplace, and if this is urgent to get the new version, you can proceed as followed : * git clone git://git.eclipse.org/gitroot/windowbuilder/org.eclipse.windowbuilder.git * cd org.eclipse.windowbuilder * mvn clean install Then install the updated p2 site found in : org.eclipse.windowbuilder/org.eclipse.wb.releng.updatesite/target/org.eclipse.wb.releng.updatesite-1.0.0-SNAPSHOT.zip I guess Wim will provide it sooner or later on the market place :)
(In reply to Olivier Prouvost from comment #15) > While it is not provided on marketplace, and if this is urgent to get the > new version, you can proceed as followed : > > * git clone > git://git.eclipse.org/gitroot/windowbuilder/org.eclipse.windowbuilder.git > * cd org.eclipse.windowbuilder > * mvn clean install > > Then install the updated p2 site found in : > > org.eclipse.windowbuilder/org.eclipse.wb.releng.updatesite/target/org. > eclipse.wb.releng.updatesite-1.0.0-SNAPSHOT.zip > > I guess Wim will provide it sooner or later on the market place :) That is not needed. The last successful build is also on the download page.
Sorry Wim, I must reopen the bug.... I can't find the latest version on the download page. If you go on this page : https://www.eclipse.org/windowbuilder/download.php you can see the Latest (1.9.2), and its update site URL is : https://download.eclipse.org/windowbuilder/latest/ This update site contains only the 1.9.2... If you go on market place, only 1.9.2 is provided also. So both of the automatic updates (market place and update site) are using 1.9.2 and not the latest 1.9.3 with the patch... If you build window builder locally you get the 1.9.3. For the moment the only way to install the patch is to build it locally...
Created attachment 281562 [details] Where to get it Olivier, you can find the latest builds here. Since you did not merge the changes yet, they can be found in the Gerrit section. After you merge the changes, the code will be found in the last good build section. Cheers, Wim
Oups ! Yes ! I forgot it :). But unfortunately I am not a committer on this project and I can not merge the request... -> who could do it ? Ok... Not really UI friendly, I didn't see it on the web site ! :) Market place should also be updated... this is the easier way to update !
Olivier, I found some issues in your patch. Would you like Gerrit comments or an update to the code?
Comment on gerrit
or make an amend if you already changed it
(In reply to Olivier Prouvost from comment #21) > Comment on gerrit (In reply to Olivier Prouvost from comment #22) > or make an amend i What do you prefer?
Gerrit change https://git.eclipse.org/r/156182 was merged to [master]. Commit: http://git.eclipse.org/c/windowbuilder/org.eclipse.windowbuilder.git/commit/?id=938262a004fd9c9196b02fffb91c7446cae76db9
I have added the nightly build as a separate market place entry. (In reply to Olivier Prouvost from comment #19) > > Ok... Not really UI friendly, I didn't see it on the web site ! :) You mean developer unfriendly because the lazy user does not want to read :) To lead the horse even closer to the water, I have added the marketplace drag buttons on the downloads page[1] and I have also added a marketplace entry for the nightly build. https://www.eclipse.org/windowbuilder/download.php https://marketplace.eclipse.org/content/windowbuilder-nightly-build
