Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 553386 - [test] clean-up of converterJclMin after bug 544943
Summary: [test] clean-up of converterJclMin after bug 544943
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.14   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: 4.15 M3   Edit
Assignee: Jay Arthanareeswaran CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-23 16:18 EST by Stephan Herrmann CLA
Modified: 2020-02-29 16:24 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2019-11-23 16:18:05 EST 
(In reply to Manoj Palat from bug 544943 comment #19)
> A combined stashed change of Olivier's patch alongwith test case changes and
> dom ast ConverterJCL additions/corrections at
> https://git.eclipse.org/r/#/c/149902/.
> 
> Tests are green.
> 
> This was pushed via
> commit:https://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/
> ?id=ae3d720efce20459d1d746646153478f03bf3002

A few things are fishy here:

* updated jar files with no updates in corresponding src.zip files 
  => nobody is able to do further maintenance here

* new class ClassNotFoundException extends ReflectiveOperationException which
  is not contained


@Manoj: were those your own additions or did you just squash changes from Olivier?
Comment 1 Manoj N Palat CLA 2019-11-25 10:49:23 EST 
Bulk move out of 4.14
Comment 2 Stephan Herrmann CLA 2020-01-05 09:01:25 EST 
Manoj, please don't let this slip until all memory is lost. The current state cannot be maintained. Hopefully you still have the missing sources on your hard drive?
Comment 3 Manoj N Palat CLA 2020-01-06 01:40:54 EST 
(In reply to Stephan Herrmann from comment #0)
> 
> @Manoj: were those your own additions or did you just squash changes from
> Olivier?

@Stephan: I am not able to recollect doing this work [neither do I have the hard drive as the machine was reinstalled] - I see Jay as the committer for the patch - so
@Jay: can you please check on this in your machine?
Comment 4 Stephan Herrmann CLA 2020-01-06 14:14:47 EST 
(In reply to Manoj Palat from comment #3)
> @Stephan: I am not able to recollect doing this work [neither do I have the
> hard drive as the machine was reinstalled] - I see Jay as the committer for
> the patch 

Sorry, I only saw you as the one commenting in bug 544943 comment #19 - didn't see you wrote that on behalf of Jay ...
Comment 5 Manoj N Palat CLA 2020-01-13 04:25:58 EST 
bulk move out of 4.15 M1
Comment 6 Eclipse Genie CLA 2020-01-23 09:13:00 EST 
New Gerrit change created: https://git.eclipse.org/r/156433
Comment 8 Stephan Herrmann CLA 2020-02-29 16:24:11 EST 
(In reply to Eclipse Genie from comment #7)
> Gerrit change https://git.eclipse.org/r/156433 was merged to [master].
> Commit:
> http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/
> ?id=1406d4d38f0de44d13f89707295b071867b2237c

This only touched one of many affected file. We're not done, content is still inconsistent -> over to bug 560658