Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 552822 - [Win32][Cocoa] Cursor to click 'x' to clear search text should be mouse arrow and not a caret
Summary: [Win32][Cocoa] Cursor to click 'x' to clear search text should be mouse arrow...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.14   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.15 M3   Edit
Assignee: Nikita Nemkin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 553846 (view as bug list)
Depends on: 293230
Blocks:
  Show dependency tree
 
Reported: 2019-11-08 03:47 EST by Noopur Gupta CLA
Modified: 2020-04-02 10:03 EDT (History)
7 users (show)

See Also:


Attachments
macos_mojave_ibeam.png (13.10 KB, image/png)
2020-01-08 02:56 EST, Nikita Nemkin CLA
no flags Details
macos_catalina_ibeam.png (25.29 KB, image/png)
2020-01-08 03:53 EST, Nikita Nemkin CLA
no flags Details
screenshot with native cursor (386.64 KB, image/png)
2020-01-09 04:20 EST, Lakshmi P Shanmugam CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2019-11-08 03:47:43 EST
I20191030-1800

Windows 10

- Type some text in a filter e.g. on the left filter in Preferences.
- Hover on 'x' to clear the filter text.

=> A caret is shown to click on 'x'.

It should be the arrow cursor as in Windows text filters.
Comment 1 Sarika Sinha CLA 2019-11-08 05:35:22 EST
On Mac also "caret" is shown, it is not intuitive. "Arrow" is shown generally.
Comment 2 Niraj Modi CLA 2019-11-08 05:45:44 EST
Hi Nikita,
Please check, if the mouse hover behavior can be improved ?
Comment 3 Sarika Sinha CLA 2019-11-08 06:00:23 EST
(In reply to Niraj Modi from comment #2)
> Hi Nikita,
> Please check, if the mouse hover behavior can be improved ?

What about Mac and other OS ?
Comment 4 Niraj Modi CLA 2019-11-08 06:04:47 EST
(In reply to Sarika Sinha from comment #3)
> (In reply to Niraj Modi from comment #2)
> > Hi Nikita,
> > Please check, if the mouse hover behavior can be improved ?
> 
> What about Mac and other OS ?

Updated the title.
Comment 5 Lakshmi P Shanmugam CLA 2019-11-12 01:59:22 EST
May be it's a general problem, Sravan can you please check on Linux?
Comment 6 Nikita Nemkin CLA 2020-01-07 08:48:48 EST
Cocoa behavior is a side effect of fixing Bug 358022. The fix is no longer relevant and can be safely reverted.

Win32 behavior is implementation oversight.
Comment 7 Eclipse Genie CLA 2020-01-07 10:08:52 EST
New Gerrit change created: https://git.eclipse.org/r/155405
Comment 8 Eclipse Genie CLA 2020-01-07 10:56:49 EST
New Gerrit change created: https://git.eclipse.org/r/155412
Comment 9 Lakshmi P Shanmugam CLA 2020-01-08 00:28:36 EST
(In reply to Nikita Nemkin from comment #6)
> Cocoa behavior is a side effect of fixing Bug 358022. The fix is no longer
> relevant and can be safely reverted.
> 
Thanks Nikita for finding this.
I checked the status of the Apple bug opened for the problem, it has been marked as duplicate and didn't find a way to check the duplicate bug. Do you know if it has been fixed by Apple and in which OS version?
Comment 10 Nikita Nemkin CLA 2020-01-08 02:56:06 EST
Created attachment 281404 [details]
macos_mojave_ibeam.png

(In reply to Lakshmi Shanmugam from comment #9)
>
> Thanks Nikita for finding this.
> I checked the status of the Apple bug opened for the problem, it has been
> marked as duplicate and didn't find a way to check the duplicate bug. Do you
> know if it has been fixed by Apple and in which OS version?

I verified with your test program (attached to Bug 358022) on 10.14 Mojave, see the comparison screenshot. Native I-Beam looks more distinct on a dark background.

As far as I remember, it always looked like this. Original bug is honestly baffling.
Comment 11 Nikita Nemkin CLA 2020-01-08 03:53:04 EST
Created attachment 281405 [details]
macos_catalina_ibeam.png

Catalina screenshot of the same test program, so the last 2 macOS versions are verified.
Comment 12 Lakshmi P Shanmugam CLA 2020-01-09 04:20:21 EST
Created attachment 281423 [details]
screenshot with native cursor

(In reply to Nikita Nemkin from comment #10)
> Created attachment 281404 [details]
> macos_mojave_ibeam.png
> 
> (In reply to Lakshmi Shanmugam from comment #9)
> >
> > Thanks Nikita for finding this.
> > I checked the status of the Apple bug opened for the problem, it has been
> > marked as duplicate and didn't find a way to check the duplicate bug. Do you
> > know if it has been fixed by Apple and in which OS version?
> 
> I verified with your test program (attached to Bug 358022) on 10.14 Mojave,
> see the comparison screenshot. Native I-Beam looks more distinct on a dark
> background.
> 
> As far as I remember, it always looked like this. Original bug is honestly
> baffling.

Unfortunately the bug is still reproducible on macOS 10.13 and 10.13 is still supported by Eclipse and Apple. With the bug, the IBeam cursor is quite hard to see in the dark theme for example in the main Text editor (screenshot attached).
I think we should keep the existing code for OS <= 10.13. Can you please update the patch so that the fix applies on 10.14+ and older code is used on 10.13 and below?
Comment 15 Nikita Nemkin CLA 2020-01-14 05:52:38 EST
Fixed for Windows and macOS 10.14+
Comment 16 Lakshmi P Shanmugam CLA 2020-01-14 06:14:24 EST
Thanks for the fixes, Nikita!
Comment 17 Lakshmi P Shanmugam CLA 2020-04-02 10:03:25 EDT
*** Bug 553846 has been marked as a duplicate of this bug. ***