Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 552476 - [Dark theme] Remove workaround for Bug 419482
Summary: [Dark theme] Remove workaround for Bug 419482
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.14   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.14 M3   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 419482
Blocks:
  Show dependency tree
 
Reported: 2019-10-28 07:52 EDT by Lars Vogel CLA
Modified: 2019-11-05 04:19 EST (History)
3 users (show)

See Also:

Attachments
Before/After on Windows (290.48 KB, image/png)
2019-11-05 04:10 EST, Benedikt Kuntz CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-10-28 07:52:06 EDT 
Bug 419482 is fixed since a very long time but the workaround in the dark CSS is still present. 

We should remove this workaround.
Comment 1 Eclipse Genie CLA 2019-10-28 08:02:23 EDT 
New Gerrit change created: https://git.eclipse.org/r/151693
Comment 2 Benedikt Kuntz CLA 2019-11-05 04:10:38 EST 
Created attachment 280508 [details]
Before/After on Windows

Screenshots on Windows, left: before; right: after

Not sure why, but this has the great advantage that the ugly background of the part toolbars is gone (at least if it is not moved to the next line).
See Console view's toolbar and project explorer's toolbar: Console View's toolbar looks perfect, project explorer's toolbar background is better but not exactly the color of the panel behind... When the project explorer is dragged to the right and the toolbar moves to the tab area (next to the maximize/minimize buttons), than it matches the background color.
Comment 3 Lars Vogel CLA 2019-11-05 04:18:47 EST 
Thanks Benedikt for testing.