Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 551319 - [Cocoa][Win] ToolItem.setDisabledImage() JUnit test failure
Summary: [Cocoa][Win] ToolItem.setDisabledImage() JUnit test failure
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.14   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.15 M3   Edit
Assignee: Lakshmi P Shanmugam CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 302918
Blocks:
  Show dependency tree
 
Reported: 2019-09-20 10:35 EDT by Eric Williams CLA
Modified: 2020-02-18 03:51 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Williams CLA 2019-09-20 10:35:55 EDT 
Part of the fixes for bug 302918 introduced a JUnit test for ToolItem.setDisabledImage. This test case is failing on Mac: http://download.eclipse.org/eclipse/downloads/drops4/I20190919-1800/testresults/html/org.eclipse.swt.tests_ep414I-unit-mac64-java8_macosx.cocoa.x86_64_8.0.html
Comment 1 Niraj Modi CLA 2019-10-04 10:38:39 EDT 
Gerrit change https://git.eclipse.org/r/150593 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=1d01c64bec0307a24800ce7fb2a5ea15e9710453

With above patch, enabled this test for GTK only.
Comment 2 Eclipse Genie CLA 2020-01-20 04:33:23 EST 
New Gerrit change created: https://git.eclipse.org/r/156173
Comment 3 Lakshmi P Shanmugam CLA 2020-01-20 04:46:35 EST 
The test was modified via https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=076c8373de27a918ae94e3a6b29303af6ba615c6 and passes now on Windows and Mac.
Comment 5 Lakshmi P Shanmugam CLA 2020-02-18 03:51:24 EST 
Tests run fine on all platforms.