551318 – [Win32] ToolItem.setDisabledImage() JUnit test failure

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 551318 - [Win32] ToolItem.setDisabledImage() JUnit test failure

Summary: [Win32] ToolItem.setDisabledImage() JUnit test failure

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	SWT (show other bugs)
Version:	4.14
Hardware:	PC All

Importance:	P3 normal (vote)
Target Milestone:	4.15
Assignee:	Platform-SWT-Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:	302918
Blocks:
	Show dependency tree

Reported:	2019-09-20 10:34 EDT by Eric Williams
Modified:	2020-03-15 09:37 EDT (History)
CC List:	2 users (show)

See Also:	551319 Gerrit Change Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Eric Williams

2019-09-20 10:34:22 EDT

Part of the fixes for bug 302918 introduced a JUnit test for ToolItem.setDisabledImage. This JUnit test seems to be failing on Windows: http://download.eclipse.org/eclipse/downloads/drops4/I20190919-1800/testresults/html/org.eclipse.swt.tests_ep414I-unit-win32-java8_win32.win32.x86_64_8.0.html

Comment 1 Niraj Modi

2019-09-21 05:40:06 EDT

(In reply to Eric Williams from comment #0)
> Part of the fixes for bug 302918 introduced a JUnit test for
> ToolItem.setDisabledImage. This JUnit test seems to be failing on Windows:
> http://download.eclipse.org/eclipse/downloads/drops4/I20190919-1800/
> testresults/html/org.eclipse.swt.tests_ep414I-unit-win32-java8_win32.win32.
> x86_64_8.0.html

This JUnit test is also failing on Cocoa:
https://download.eclipse.org/eclipse/downloads/drops4/I20190919-1800/testresults/html/org.eclipse.swt.tests_ep414I-unit-mac64-java8_macosx.cocoa.x86_64_8.0.html

Comment 2 Niraj Modi

2019-10-04 09:49:11 EDT

For now I am enabling this test for GTK only.

Comment 3 Eclipse Genie

2019-10-04 09:50:18 EDT

New Gerrit change created: https://git.eclipse.org/r/150593

Comment 4 Eclipse Genie

2019-10-04 10:37:18 EDT

Gerrit change https://git.eclipse.org/r/150593 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=1d01c64bec0307a24800ce7fb2a5ea15e9710453

Comment 5 Conrad Groth

2020-03-15 09:36:07 EDT

The test was re-enabled by Lakshmi Shanmugam with commit https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=644ff1b053bc09ac9e6829e883a7bdeaaf2afc79