Comment 1 Vikas Chandra 2019-09-12 01:58:47 EDT

Hi Mickael, can you take care of this?

Comment 2 Mickael Istria 2019-09-12 02:24:06 EDT

Which bunlde do you have in mind in particumar?
When progile is acgive,api-xhexk is enabled by default on all bundles, unless explicitly skipped, so I don't really get what this resuest is about.

Comment 3 Sravan Kumar Lakkimsetti 2019-09-12 06:09:22 EDT

Api check doesn't work for new bundles which were added. These had to be explicitly disabled for that bundle.

Need to scan source for these explicit exclusions and enable API check for them as we will have baseline.

Comment 4 Mickael Istria 2019-09-12 13:45:47 EDT

I only see org.eclipse.text.quicksearch added in 4.13. Do you have other ones in mind?
Note that it's only a matter of removing the skipAPIBasline property in desired pom file, nothing that requires huge expertise to make me a bottleneck here.

Comment 5 Sravan Kumar Lakkimsetti 2019-09-13 02:22:46 EDT

(In reply to Mickael Istria from comment #4)
> I only see org.eclipse.text.quicksearch added in 4.13. Do you have other
> ones in mind?
> Note that it's only a matter of removing the skipAPIBasline property in
> desired pom file, nothing that requires huge expertise to make me a
> bottleneck here.

I agree with Mickael here. What needs to be done is already documented by Mickael in https://wiki.eclipse.org/Platform-releng/Checklist#Update_build_scripts.2C_branding.2C_and_test_jobs 

Assigning to Vikas for action as he is the release engineer for 4.14

Comment 6 Eclipse Genie 2019-09-13 10:27:07 EDT

New Gerrit change created: https://git.eclipse.org/r/149487

Comment 7 Eclipse Genie 2019-09-13 11:06:58 EDT

Gerrit change https://git.eclipse.org/r/149487 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=475518e35dc1ba083174fc6387e19479ead28638

Comment 8 Mickael Istria 2019-09-13 11:07:17 EDT

Marking as resolved as I fixed org.eclipse.text.quicksearch and am not aware of other concerned modules.