Comment 1 Eclipse Genie 2019-07-16 07:05:15 EDT

New Gerrit change created: https://git.eclipse.org/r/146162

Comment 2 Kalyan Prasad Tatavarthi 2019-07-17 03:08:53 EDT

Created attachment 279298 [details]
New combined QuickFix

The change https://git.eclipse.org/r/146162 includes code to combine changing the project compliance to 13 as well as to enable the previews in a single QuickFix. This attachment shows the way UI will look for the quick assist. Please provide your feedback.

Comment 3 Eclipse Genie 2019-07-18 05:22:29 EDT

Gerrit change https://git.eclipse.org/r/146162 was merged to [BETA_JAVA13].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=2a8be27e7987ce27ef1a52e30e4bbfba16a515ff

Comment 4 Eclipse Genie 2019-07-18 05:44:06 EDT

New Gerrit change created: https://git.eclipse.org/r/146301

Comment 5 Eclipse Genie 2019-07-18 05:44:07 EDT

Gerrit change https://git.eclipse.org/r/146301 was merged to [BETA_JAVA13].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=7e3878ecc0daebc7e32da33eb8e5a599e2df0811

Comment 6 Eclipse Genie 2019-07-18 05:50:42 EDT

New Gerrit change created: https://git.eclipse.org/r/146303

Comment 7 Eclipse Genie 2019-07-18 05:51:23 EDT

Gerrit change https://git.eclipse.org/r/146303 was merged to [BETA_JAVA13].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=4fcc26a2ff8fb76799c478b5cbb4baab0159ddb6

Comment 8 Noopur Gupta 2019-07-23 05:55:11 EDT

Y20190722-0900

1. WARNING in /ui/org/eclipse/jdt/internal/ui/text/correction/ReorgCorrectionsSubProcessor.java
 (at line 391)
public ChangeToRequiredCompilerCompliance(String name, IJavaProject project, boolean changeOnWorkspace, String requiredVersion, int relevance) {
The constructor ReorgCorrectionsSubProcessor.ChangeToRequiredCompilerCompliance(String, IJavaProject, boolean, String, int) is never used locally

Let's keep the bug open until this is resolved (either remove the unused constructor or reorganize the code to prevent the warning).

Comment 9 Noopur Gupta 2019-07-25 02:53:33 EDT

It also seems to be causing the following test failures in the Y-build:
QuickFixTest12.testAddDefaultCaseSwitchExpression1() 
QuickFixTest12.testAddDefaultCaseSwitchExpression2() 

Kalyan, can you please check?

Comment 10 Noopur Gupta 2019-07-25 02:54:14 EDT

(In reply to Noopur Gupta from comment #9)
> It also seems to be causing the following test failures in the Y-build:
> QuickFixTest12.testAddDefaultCaseSwitchExpression1() 
> QuickFixTest12.testAddDefaultCaseSwitchExpression2() 
> 
> Kalyan, can you please check?
Here's the stack trace:

java.lang.ClassCastException: org.eclipse.jdt.internal.ui.text.correction.ReorgCorrectionsSubProcessor$ChangeToRequiredCompilerCompliance cannot be cast to org.eclipse.jdt.ui.text.java.correction.CUCorrectionProposal
	at org.eclipse.jdt.ui.tests.quickfix.QuickFixTest12.testAddDefaultCaseSwitchExpression1(QuickFixTest12.java:456)
...

Comment 11 Eclipse Genie 2019-07-31 06:23:42 EDT

New Gerrit change created: https://git.eclipse.org/r/146851

Comment 12 Eclipse Genie 2019-07-31 07:03:44 EDT

Gerrit change https://git.eclipse.org/r/146851 was merged to [BETA_JAVA13].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=e72e96cda4b882d9ba2a459aee4af5093b78df87

Comment 13 Kalyan Prasad Tatavarthi 2019-07-31 07:04:55 EDT

(In reply to Noopur Gupta from comment #10)
> (In reply to Noopur Gupta from comment #9)
> > It also seems to be causing the following test failures in the Y-build:
> > QuickFixTest12.testAddDefaultCaseSwitchExpression1() 
> > QuickFixTest12.testAddDefaultCaseSwitchExpression2() 
> > 
> > Kalyan, can you please check?
> Here's the stack trace:
> 
> java.lang.ClassCastException:
> org.eclipse.jdt.internal.ui.text.correction.
> ReorgCorrectionsSubProcessor$ChangeToRequiredCompilerCompliance cannot be
> cast to org.eclipse.jdt.ui.text.java.correction.CUCorrectionProposal
> 	at
> org.eclipse.jdt.ui.tests.quickfix.QuickFixTest12.
> testAddDefaultCaseSwitchExpression1(QuickFixTest12.java:456)
> ...

 The patch https://git.eclipse.org/r/146851

1) Handled the case of warning in ReorgCorrectionsSubProcessor.
2) Disabled the two failing tests. Need to enable them once RTStubs13 is
ready.