Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 549220 - [13] Organize imports should handle types in YieldStatement
Summary: [13] Organize imports should handle types in YieldStatement
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.13   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: BETA J13   Edit
Assignee: Noopur Gupta CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 548096
  Show dependency tree
 
Reported: 2019-07-12 08:38 EDT by Noopur Gupta CLA
Modified: 2019-10-03 04:15 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2019-07-12 08:38:10 EDT 
Organize imports should handle types in yield expression. Also, for Java 12, types should still be handled in break expression.
Comment 1 Eclipse Genie CLA 2019-07-12 08:48:08 EDT 
New Gerrit change created: https://git.eclipse.org/r/145980
Comment 2 Noopur Gupta CLA 2019-07-12 09:09:23 EDT 
(In reply to Noopur Gupta from comment #0)
> Also, for Java 12, types should still be handled in break expression.

This will not be required as the compiler itself does not support break expressions for Java 12 now.
Comment 4 Roland Grunberg CLA 2019-10-02 10:24:10 EDT 
Just thought I'd mention my apitools (based on Eclipse 4.13 SDK) seems to complain about :

Missing @since tag on visit(YieldStatement)	ImportReferencesCollector.java	/org.eclipse.jdt.core.manipulation/common/org/eclipse/jdt/core/manipulation	line 308	@since tag problem

The method org.eclipse.jdt.core.manipulation.ImportReferencesCollector.visit(BreakStatement) has been removed	ImportReferencesCollector.java	/org.eclipse.jdt.core.manipulation/common/org/eclipse/jdt/core/manipulation	line 74	Compatibility Problem

I'm not sure why the complaint on removal of visit(BreakStatement) because it just falls back to the inherited one, and even visit(YieldStatement) had an implementation inherited from GenericVisitor.

I wonder if it's just a bug in the tooling.
Comment 5 Noopur Gupta CLA 2019-10-03 04:15:57 EDT 
(In reply to Roland Grunberg from comment #4)
> Just thought I'd mention my apitools (based on Eclipse 4.13 SDK) seems to
> complain about :
> ...
> I wonder if it's just a bug in the tooling.

I am currently using I20190919-1800 with 4.13 SDK as API baseline and I don't see these errors. It looks like a problem in API tooling. If it wasn't showing up for you until I20190919-1800 then it could be a regression in PDE API tools or it can be some configuration issue. Can you please open a bug report for PDE API tools? I will also move to the latest I-build in the next week and check if I see these issues.