Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 548171 - [win32] 4.13 I build failure due to SWT native build failure
Summary: [win32] 4.13 I build failure due to SWT native build failure
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.13   Edit
Hardware: PC All
: P3 blocker (vote)
Target Milestone: 4.13 M1   Edit
Assignee: Niraj Modi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 293230
  Show dependency tree
 
Reported: 2019-06-12 00:01 EDT by Sarika Sinha CLA
Modified: 2019-07-09 05:33 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sarika Sinha CLA 2019-06-12 00:01:54 EDT 
Waiting for the completion of 1-SWT-Increment_if_needed
03:32:08 1-SWT-Increment_if_needed #664 completed. Result was FAILURE
03:32:08 Build step 'Trigger/call builds on other projects' marked build as failure

https://ci.eclipse.org/releng/job/1-SWT-Increment_if_needed/664/console
Comment 1 Sravan Kumar Lakkimsetti CLA 2019-06-12 00:14:32 EDT 
Here is the actual error message
"swt.rc(55) : error RC2176 : old DIB in search.ico; pass it through SDKPAINT

NMAKE : fatal error U1077: '"C:\Program Files (x86)\Windows Kits\10\bin\10.0.16299.0\x64\rc.EXE"' : return code '0x1'
Stop."



My suspicion is on this commit https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=c4446b5e7d895c1bbe3231a1b6440910c7c14932 

looks like we have a problem with ico format.

@niraj, Can we revert this?
Comment 2 Niraj Modi CLA 2019-06-12 00:32:09 EDT 
(In reply to Sravan Kumar Lakkimsetti from comment #1)
> Here is the actual error message
> "swt.rc(55) : error RC2176 : old DIB in search.ico; pass it through SDKPAINT
> 
> NMAKE : fatal error U1077: '"C:\Program Files (x86)\Windows
> Kits\10\bin\10.0.16299.0\x64\rc.EXE"' : return code '0x1'
> Stop."
> 
> 
> 
> My suspicion is on this commit
> https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=c4446b5e7d895c1bbe3231a1b6440910c7c14932 
> 
> looks like we have a problem with ico format.
> 
> @niraj, Can we revert this?

Native build pass locally, but is failing on build machine.
I plan to revert above patch for now.
Comment 3 Niraj Modi CLA 2019-06-12 00:39:35 EDT 
(In reply to Sravan Kumar Lakkimsetti from comment #1)
> My suspicion is on this commit
> https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=c4446b5e7d895c1bbe3231a1b6440910c7c14932 

Above patch is reverted via below commit:
Gerrit change https://git.eclipse.org/r/143789 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=6434e727aafcb8d724a9bab0c65f18e15e6b596b
Comment 4 Sarika Sinha CLA 2019-06-12 04:55:15 EDT 
New Build has come.
Comment 5 Niraj Modi CLA 2019-07-09 05:33:38 EDT 
Marking Verified.