Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 548060 - [Preferences] Improve positioning of widgets on Annotations page
Summary: [Preferences] Improve positioning of widgets on Annotations page
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.13   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.13 M1   Edit
Assignee: Andrew Obuchowicz CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 548059 (view as bug list)
Depends on:
Blocks: 548042
  Show dependency tree
 
Reported: 2019-06-07 12:09 EDT by Andrew Obuchowicz CLA
Modified: 2019-07-10 14:26 EDT (History)
2 users (show)

See Also:


Attachments
Suggested fix (88.89 KB, image/png)
2019-06-07 12:09 EDT, Andrew Obuchowicz CLA
no flags Details
Preview of what the suggested fix would look like (87.24 KB, image/png)
2019-06-07 12:11 EDT, Andrew Obuchowicz CLA
no flags Details
scrolled annotation list (25.32 KB, image/png)
2019-06-11 15:30 EDT, Paul Pazderski CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Obuchowicz CLA 2019-06-07 12:09:11 EDT
Where it occurs:
Preferences -> General -> Editors -> Text Editors -> Annotations

The "include in next/previous navigation" checkbox isin't alligned with all the widgets above it. I suggest moving all those widgets to the left (see attached pictures).
Comment 1 Andrew Obuchowicz CLA 2019-06-07 12:09:59 EDT
Created attachment 278859 [details]
Suggested fix
Comment 2 Andrew Obuchowicz CLA 2019-06-07 12:11:08 EDT
Created attachment 278860 [details]
Preview of what the suggested fix would look like
Comment 3 Andrew Obuchowicz CLA 2019-06-11 15:11:44 EDT
It might make more sense to move all of the widgets (which are currently to the right of the table) underneath the table.
Comment 4 Paul Pazderski CLA 2019-06-11 15:30:33 EDT
Created attachment 278901 [details]
scrolled annotation list

My annotations list already has scrollbars and instead would profit if the table grow and shrink with the preference window. Beside that my screen has more pixel in width than in height.
Comment 5 Dani Megert CLA 2019-06-12 04:09:25 EDT
(In reply to Andrew Obuchowicz from comment #3)
> It might make more sense to move all of the widgets (which are currently to
> the right of the table) underneath the table.
-1 for that because the distance from the selected annotation to its settings would be bigger.
Comment 6 Alexander Kurtakov CLA 2019-06-12 11:07:44 EDT
*** Bug 548059 has been marked as a duplicate of this bug. ***
Comment 7 Andrew Obuchowicz CLA 2019-06-12 11:25:31 EDT
(In reply to Paul Pazderski from comment #4)
> Created attachment 278901 [details]
> scrolled annotation list
> 
> My annotations list already has scrollbars and instead would profit if the
> table grow and shrink with the preference window. Beside that my screen has
> more pixel in width than in height.

Thank you for the input Paul, very insightful in helping me approach this problem
Comment 8 Andrew Obuchowicz CLA 2019-06-12 11:31:18 EDT
(In reply to Dani Megert from comment #5)
> (In reply to Andrew Obuchowicz from comment #3)
> > It might make more sense to move all of the widgets (which are currently to
> > the right of the table) underneath the table.
> -1 for that because the distance from the selected annotation to its
> settings would be bigger.

Good point.

As mentioned by Paul, perhaps it'd be better to try and make it so that the table dynamically resizes with the window (and the widgets try to keep their relative positioning)? This could potentially be done using GridLayout.
Comment 9 Andrew Obuchowicz CLA 2019-06-12 11:33:42 EDT
Comment on attachment 278860 [details]
Preview of what the suggested fix would look like

Additionally, is there any issue with alligning the widgets with the "Include in next/previous navigation" check box ? (As depicted in the attachment image)
Comment 10 Dani Megert CLA 2019-06-12 11:38:24 EDT
(In reply to Andrew Obuchowicz from comment #9)
> Additionally, is there any issue with alligning the widgets with the
> "Include in next/previous navigation" check box ? (As depicted in the
> attachment image)
That sounds OK to me.
Comment 11 Eclipse Genie CLA 2019-06-13 13:11:37 EDT
New Gerrit change created: https://git.eclipse.org/r/143986
Comment 13 Dani Megert CLA 2019-06-16 10:16:49 EDT
Thanks Andrew.
Comment 14 Andrew Obuchowicz CLA 2019-06-17 09:39:43 EDT
(In reply to Dani Megert from comment #13)
> Thanks Andrew.

Thank you for the code review Dani.

Should I open a new bug regarding making the table on the Annotations page grow/shrink with the window? (See Paul's comment) 

I am currently working on another patch but am willing to try and address Paul's issue once I have a moment.