Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 547682 - Update Eclipse Marketplace entries for AST View and Java Element view
Summary: Update Eclipse Marketplace entries for AST View and Java Element view
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.12   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.13 M1   Edit
Assignee: Kalyan Prasad Tatavarthi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 547673
  Show dependency tree
 
Reported: 2019-05-27 05:38 EDT by Noopur Gupta CLA
Modified: 2019-06-25 02:18 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2019-05-27 05:38:14 EDT 
Some pointers to help with the update:

- http://git.eclipse.org/c/www.eclipse.org/jdt.git/tree/ui/update-site/content/site.xml

- ui/update-site/content/Readme.txt from  https://git.eclipse.org/c/www.eclipse.org/jdt.git/

- Features in the same repo - they should be updated if not done already
	org.eclipse.jdt.astview.feature
	org.eclipse.jdt.jeview.feature

- the update site in https://git.eclipse.org/c/www.eclipse.org/jdt.git/ - 	ui/update-site

- the actual content is located in https://archive.eclipse.org/jdt/ui/update-site/
Comment 1 Noopur Gupta CLA 2019-05-28 07:12:51 EDT 
(In reply to Noopur Gupta from comment #0)
> - ui/update-site/content/Readme.txt from 
> https://git.eclipse.org/c/www.eclipse.org/jdt.git/

Initial steps from Readme.txt:

- check out org.eclipse.license from git://git.eclipse.org/gitroot/cbi/org.eclipse.license.git
- open site.xml
- add a new feature version or select the current feature version to rebuild
- click "Build"

I checked out and imported org.eclipse.license in the workspace. Selecting an existing feature in site.xml and clicking "Build" gives the error: "Unable to find feature: org.eclipse.license."

Vikas, any pointers on this?
Comment 2 Vikas Chandra CLA 2019-05-28 09:31:10 EDT 
>>Vikas, any pointers on this?

Anything in error log?
Comment 3 Noopur Gupta CLA 2019-05-28 09:43:21 EDT 
(In reply to Vikas Chandra from comment #2)
> >>Vikas, any pointers on this?
> 
> Anything in error log?
Just the error "Unable to find feature: org.eclipse.license." without any stack trace.
Comment 4 Noopur Gupta CLA 2019-06-04 04:07:11 EDT 
Kalyan looked into it and is providing the fix. Thanks, Kalyan!
Comment 5 Noopur Gupta CLA 2019-06-04 06:02:16 EDT 
(In reply to Noopur Gupta from comment #3)
> (In reply to Vikas Chandra from comment #2)
> > >>Vikas, any pointers on this?
> > 
> > Anything in error log?
> Just the error "Unable to find feature: org.eclipse.license." without any
> stack trace.
Launching Eclipse with Java 8 instead of 11 still had this issue. I will try in a new workspace.
Comment 6 Noopur Gupta CLA 2019-06-04 08:00:41 EDT 
We tried the updated JARs but they had some issues. It needs more time for investigation. So, it has been reverted back to the old state for now. To be checked next week.

Also, Kalyan has modified the Readme file with updated steps.
Comment 7 Eclipse Genie CLA 2019-06-12 09:49:01 EDT 
New Gerrit change created: https://git.eclipse.org/r/143834
Comment 8 Eclipse Genie CLA 2019-06-13 00:36:17 EDT 
New Gerrit change created: https://git.eclipse.org/r/143919
Comment 10 Eclipse Genie CLA 2019-06-14 04:36:34 EDT 
New Gerrit change created: https://git.eclipse.org/r/144022
Comment 11 Noopur Gupta CLA 2019-06-14 04:49:30 EDT 
Tested AST View 1.1.10.201906121540 installed from Eclipse marketplace on Eclipse 4.12 (I20190605-1800) build and it works fine.
Comment 13 Sarika Sinha CLA 2019-06-25 01:33:30 EDT 
Please reopen if some task is left.
Comment 14 Noopur Gupta CLA 2019-06-25 02:18:46 EDT 
(In reply to Eclipse Genie from comment #8)
> New Gerrit change created: https://git.eclipse.org/r/143919

This is pending to be released. Kalyan, please check.