Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 547468 - Retire JDT old template migration from 2004 in JDT UI activator
Summary: Retire JDT old template migration from 2004 in JDT UI activator
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.12   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.13 M1   Edit
Assignee: Lars Vogel CLA
QA Contact: Roland Grunberg CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-20 04:55 EDT by Lars Vogel CLA
Modified: 2019-07-16 12:50 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-05-20 04:55:46 EDT
JavaPlugin contains template migration from 2004. I believe it is save that all customers which were affected by this did migrate and suggest to remove the code.

To test,  start Eclipse with a clean workspace and set line 862 to the following:

boolean alreadyMigrated= true;

and compare the result of fCodeTemplateStore after the load call.
Comment 1 Eclipse Genie CLA 2019-05-20 05:05:54 EDT
New Gerrit change created: https://git.eclipse.org/r/142422
Comment 3 Lars Vogel CLA 2019-06-11 15:13:15 EDT
A big thanks, Roland for your timely reviews. Contributing to JDT UI is a pleasure with you as reviewer.

I hope that Eclipse will now start a tiny little bit faster with this outdated code removed.
Comment 4 Roland Grunberg CLA 2019-07-16 12:50:07 EDT
Verified for 4.13 M1 using I20190711-1805 build.