Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 546697 - [Cocoa] Update bridgesupport files to macOS 10.14 Mojave
Summary: [Cocoa] Update bridgesupport files to macOS 10.14 Mojave
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.12   Edit
Hardware: PC Mac OS X
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Nikita Nemkin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 546696
Blocks:
  Show dependency tree
 
Reported: 2019-04-24 09:31 EDT by Nikita Nemkin CLA
Modified: 2021-04-09 18:48 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Nemkin CLA 2019-04-24 09:31:42 EDT
Mojave introduced Dark Mode, which is relevant to SWT.

Also, it would be nice to add missing frameworks and migrate most of the remaining manual definitions to MacGenerator.
Comment 1 Eclipse Genie CLA 2019-04-24 17:06:04 EDT
New Gerrit change created: https://git.eclipse.org/r/141097
Comment 2 Eclipse Genie CLA 2019-04-24 17:06:05 EDT
New Gerrit change created: https://git.eclipse.org/r/141096
Comment 3 Eclipse Genie CLA 2019-04-25 02:12:26 EDT
New Gerrit change created: https://git.eclipse.org/r/141096
Comment 4 Lakshmi P Shanmugam CLA 2019-04-30 07:28:31 EDT
Thanks for the patches.

I'm not sure if we can move the bridgesupport files to use 10.14 SDK for 4.12 release. 
SWT supports at least 2 older macOS releases, so atleast 10.12 SDK has to be supported. The build machine also uses 10.12 SDK for the build.
In the last round, bridgesupport files were updated to 10.11.

(Earlier bugs to update the bridge support files: Bug 502090, Bug 514191)
Comment 5 Nikita Nemkin CLA 2019-04-30 07:45:02 EDT
(In reply to Lakshmi Shanmugam from comment #4)
> Thanks for the patches.
> 
> I'm not sure if we can move the bridgesupport files to use 10.14 SDK for
> 4.12 release. 
> SWT supports at least 2 older macOS releases, so atleast 10.12 SDK has to be
> supported. The build machine also uses 10.12 SDK for the build.
> In the last round, bridgesupport files were updated to 10.11.

Isn't 10.10 the minimum supported version? (Cocoa build.sh sets MACOSX_DEPLOYMENT_TARGET=10.10)

New SDK does support older macOS versions, as long as deployment target is set correctly.

But you're right that build machine would have to use 10.14 SDK. I'm surprised that buildbot gave +1 on Gerrit.
Comment 6 Lakshmi P Shanmugam CLA 2019-04-30 08:25:15 EDT
(In reply to Nikita Nemkin from comment #5)
> (In reply to Lakshmi Shanmugam from comment #4)
> > Thanks for the patches.
> > 
> > I'm not sure if we can move the bridgesupport files to use 10.14 SDK for
> > 4.12 release. 
> > SWT supports at least 2 older macOS releases, so atleast 10.12 SDK has to be
> > supported. The build machine also uses 10.12 SDK for the build.
> > In the last round, bridgesupport files were updated to 10.11.
> 
> Isn't 10.10 the minimum supported version? (Cocoa build.sh sets
> MACOSX_DEPLOYMENT_TARGET=10.10)
> 
Yes. We didn't have any reason to break or move up from 10.10 support. 
We only updated the bridgesupport files so that we can use the new Classes, APIs and remove deprecated ones.

> New SDK does support older macOS versions, as long as deployment target is
> set correctly.
> 
> But you're right that build machine would have to use 10.14 SDK. I'm
> surprised that buildbot gave +1 on Gerrit.

That's because, Gerrit build runs on Linux, it compiles the Java code for all platforms, but doesn't validate the native code. Also, tests are run only for Linux/GTK.
Comment 7 Lakshmi P Shanmugam CLA 2021-04-09 18:48:34 EDT
@Nikita,
The build machine has been updated and now has the latest SDK (11.1). Would you be interested in updating the bridgesupport files?