Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 546673 - [theme] Background color problem in Package Explorer with Classic theme
Summary: [theme] Background color problem in Package Explorer with Classic theme
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.12   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 4.12 M3   Edit
Assignee: Paul Pazderski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 544446 547085 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-04-23 16:19 EDT by Paul Pazderski CLA
Modified: 2019-05-08 07:15 EDT (History)
4 users (show)

See Also:

Attachments
background on startup (5.64 KB, image/png)
2019-04-23 16:21 EDT, Paul Pazderski CLA 		no flags Details
background after perspective switch (6.05 KB, image/png)
2019-04-23 16:23 EDT, Paul Pazderski CLA 		no flags Details
same problem on Ubuntu Mate 18.10 Ambiant-Mate-Dark (47.57 KB, image/png)
2019-04-23 18:03 EDT, Paul Pazderski CLA 		no flags Details
same problem on Ubuntu Mate 18.10 Ambiant-Mate (48.70 KB, image/png)
2019-04-23 18:03 EDT, Paul Pazderski CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Pazderski CLA 2019-04-23 16:19:59 EDT 
Screenshot below. The same problem exist for Project Explorer.

How to reproduce:
 - Set Theme to Classic
 - Open Package Explorer (without any projects so the guidance links are visible)
 - The background should be white like in the first screenshot
 - Switch to debug perspective and switch back
 - Now the background should be gray like in the second screenshot
Comment 1 Andrey Loskutov CLA 2019-04-23 16:20:51 EDT 
I believe I've reported this already.
Comment 2 Eclipse Genie CLA 2019-04-23 16:21:36 EDT 
New Gerrit change created: https://git.eclipse.org/r/141019
Comment 3 Paul Pazderski CLA 2019-04-23 16:21:45 EDT 
Created attachment 278373 [details]
background on startup
Comment 4 Paul Pazderski CLA 2019-04-23 16:23:24 EDT 
Created attachment 278374 [details]
background after perspective switch
Comment 5 Thomas Wolf CLA 2019-04-23 17:33:05 EDT 
(In reply to Andrey Loskutov from comment #1)
> I believe I've reported this already.

See bug 544446 and bug 514649, but those are for Linux. Don't know if there's another report for Windows for this.
Comment 6 Paul Pazderski CLA 2019-04-23 18:03:24 EDT 
Created attachment 278375 [details]
same problem on Ubuntu Mate 18.10 Ambiant-Mate-Dark

Bug 544446 seems to be the same but my steps to reproduce stay the same and I see no influence from view inactivity.

Can not say something to bug 514649 since I never noticed background changes on deactivation.
Comment 7 Paul Pazderski CLA 2019-04-23 18:03:41 EDT 
Created attachment 278376 [details]
same problem on Ubuntu Mate 18.10 Ambiant-Mate
Comment 8 Paul Pazderski CLA 2019-04-23 18:17:42 EDT 
After I saw the other bugs which go in a quite different direction I may explain my change a bit since some context may not easy visible from the change itself.

(In reply to Andrey Loskutov from big 544446 comment #12)
> It is worse. It must be in our CSS themes, because if I switch off theming,
> everything works as expected.
From what I found on this bug, which is probably the same as bug 544446, I guess disabled theming works because the two background colors are by chance the same.

For my change I debugged how the background color is set on start up (the good looking variant) and what is different on perspective switch (the bad looking). And I found on startup the background is set in EmptyWorkspaceHelper#setNonEmptyControl but not after perspective switch where EmptyWorkspaceHelper#recreateEmptyArea is used. My change simply set the background on both cases the same way.
Comment 9 Matthias Becker CLA 2019-04-24 03:05:07 EDT 
*** Bug 544446 has been marked as a duplicate of this bug. ***
Comment 11 Matthias Becker CLA 2019-04-24 04:34:08 EDT 
That's a good catch.
Thank you Paul for fixing this.
Comment 12 Paul Pazderski CLA 2019-05-08 06:05:39 EDT 
*** Bug 547085 has been marked as a duplicate of this bug. ***
Comment 13 Simeon Andreev CLA 2019-05-08 06:37:13 EDT 
Thanks Paul, didn't see this bug!
Comment 14 Andrey Loskutov CLA 2019-05-08 07:15:38 EDT 
(In reply to Simeon Andreev from comment #13)
> Thanks Paul, didn't see this bug!

Simeon, as I've already mentioned, if you hack on SDK you should use most recent nightly builds. I've described the workflow in bug 545164 and I hope we can make it easier to update every day. We plan to work on this in context of this year GSOC.