Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 546276 - [regression] No previous choices are shown in the quick access
Summary: [regression] No previous choices are shown in the quick access
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.12   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.12 M1   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 546187
  Show dependency tree
 
Reported: 2019-04-10 05:12 EDT by Andrey Loskutov CLA
Modified: 2019-04-11 09:35 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2019-04-10 05:12:42 EDT 
Follow up on bug 546217, caused by changes in bug 546187
Steps:
1. Open an existing workspace which has previous searches in quick access
2. Press Cmd+3 to open the quick access search
3. No previous searches are shown in the quick access
Comment 1 Dani Megert CLA 2019-04-10 05:59:11 EDT 
Can one of you look into this for today? We have the last build tonight and loosing the previous choices is a bad user experience.
Comment 2 Mickael Istria CLA 2019-04-10 06:20:58 EDT 
(In reply to Dani Megert from comment #1)
> Can one of you look into this for today? We have the last build tonight and
> loosing the previous choices is a bad user experience.

I'll try to have a look but I'm extremely busy on personal side today so I'm not really optimimistic I'll manage to find a solution. But I'll try.
Comment 3 Eclipse Genie CLA 2019-04-10 12:40:37 EDT 
New Gerrit change created: https://git.eclipse.org/r/140379
Comment 4 Mickael Istria CLA 2019-04-10 12:42:00 EDT 
I created a test case: https://git.eclipse.org/r/140379 . It confirms the commit did introduce the regression, and can help troubleshooting the issue more easily and will help preventing it in the future.
It's all I can do for today, I can try to work on the resolution on tomorrow.
Comment 5 Mickael Istria CLA 2019-04-11 04:48:52 EDT 
New patch set seems to fix it (at least, the test that's added is now green and some manual test show it's working here). I guess it's too late for M1 ?
Comment 6 Dani Megert CLA 2019-04-11 05:51:08 EDT 
(In reply to Mickael Istria from comment #5)
> New patch set seems to fix it (at least, the test that's added is now green
> and some manual test show it's working here). I guess it's too late for M1 ?
Looking at it now (was away before).
Comment 8 Dani Megert CLA 2019-04-11 06:11:40 EDT 
(In reply to Mickael Istria from comment #5)
> I guess it's too late for M1 ?
I've merged the change and we will do a rebuild for this.
Comment 9 Mickael Istria CLA 2019-04-11 06:21:13 EDT 
(In reply to Dani Megert from comment #8)
> I've merged the change and we will do a rebuild for this.

Ok, thanks.
Comment 10 Dani Megert CLA 2019-04-11 09:35:20 EDT 
Verified with eclipse-SDK-I20190411-0625-win32-x86_64.