Community
Participate
Working Groups
As described in bug 54547, the About dialog will be changed to get info from IProduct and IBundleGroup rather than the platform configuration. The update manager (actually update configurator) is now responsible for providing a Product (primary feature) and BundleGroups (features), and the property values defined the IProductConstants and IBundleGroupConstants.
Nick, I released some changes to provide almost all the methods for IBundleGroup and IProduct, as well as the required properties. If you have a chance to test it tomorrow, perhaps we can fix any outstanding issues and have the code ready for the next integration build. To do's: provide IProduct.getBundles() and getDescription().
Andrew, can you check this out? Presumably you'll need to load o.e.update.configurator from head along with the other runtime and osgi projects.
You should be able to get things going by just checking out the org.eclipse.update.configurator project.
As discussed in email the update implementation of IBundleGroup.getBundles() is not yet implemented. I've put a workaround into my fix for bug 54548, but cannot completely resolve that issue until this one is fixed.
See also bug 57528.
The remaining API's (getBundles() and getDescription() have been implemented. Question: in the past, the unmanaged plugins (those not contained by any feature) were not displayed. This is still the case, so I was wondering if I should create another bundle group ("Unmanged Plugins") for those plugins.
+1
Forgot to mention that there is performance cost for providing a dummy bundle group with all the unmanaged plugins: this forces all the feature.xml to be parsed (to find out what plugins they contain), and to also partially parse all the plugin.xml files (to get their id and version). The comparison step that follows should be relatively shorter compared to parsing.
I think we decided a while back that we didn't want to parse the feature.xml's just to bring up the About dialog. On the other hand, I think it does make sense for the About dialog to show all plugins/bundles. In the AboutPluginsDialog, rather than getting the list of plugins by iterating over the IBundleGroupProviders, we should just get the complete list from Runtime. I've filed bug 57960 for this.
With just the eclipse SDK plugins, the performance loss is negligible but I like your suggestion of using the runtime to get the list of all bundles. This will also show all the unamanged plugins, so they don't have to be listed on a separate bundle group provider. Good that you added the comment, I was about to release the code to define a dummy bundle group for unmanaged plugins :-). I will then mark the bug as fixed
