Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 54534 - background colors in labels for warning/errors/csv status
Summary: background colors in labels for warning/errors/csv status
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P4 enhancement (vote)
Target Milestone: 3.1 M3   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 61869
Blocks:
  Show dependency tree
 
Reported: 2004-03-11 16:00 EST by Fabrizio Giustina CLA
Modified: 2004-11-05 08:11 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabrizio Giustina CLA 2004-03-11 16:00:36 EST
Actually label decorations for warning/errors/cvs conflicts are only 
represented by a small icon or a ">" sign. Sometimes it's really difficult to 
see such small labels, expecially if you have more decorations.

Allowing users to select a backgroung/foreground color for labels will really 
improve user experience.

A similar feature is currently implemented in instantiations codepro, but only 
using custom views (they call them package explorer+, resources+). It sound 
strange to reimplement views only to add a (also if useful) background color... 
it would be really great to have a support for this feature available in the 
base UI framework, so that could be used in any view.

This is a screeshot from codepro colored view:
http://www.instantiations.com/codepro/ws/docs/images/package_explorer_plus_view.
gif

And the preference page where users can choose colors:
http://www.instantiations.com/codepro/ws/docs/images/preferences_browsers.gif

This would be a nice addiction in the new [workbench]->[colors and fonts] 
preference page just added with the new look'n feel.
Comment 1 Nick Edgar CLA 2004-03-11 23:48:39 EST
I'm all for nice addictions <g>.
Comment 2 Jean-Michel Lemieux CLA 2004-03-12 08:25:55 EST
Actually, once the ILightweight decorator implements IColorProvider and 
IFontProvider we could possibly allow customization of these for the CVS 
decorator. Until then, since our decorator is an ILightWeightDecorator, we 
can't do anything about it.
Comment 3 Tod Creasey CLA 2004-03-16 10:28:11 EST
We won't be doing this in the 3.0 timeframe.
Comment 4 Tod Creasey CLA 2004-03-16 10:28:33 EST
Marking later
Comment 5 Tod Creasey CLA 2004-06-28 11:28:25 EDT
Reopening now that 3.0 has shipped
Comment 6 Tod Creasey CLA 2004-07-06 14:29:30 EDT
Related to Bug 61869
Comment 7 Tod Creasey CLA 2004-07-06 16:12:37 EDT
This is actually not that hard.

We would need to change IDecoration to also allow colours but as no one is 
meant to implement that this would not be a breaking change.

Likewise IDecoratorManager could add a getColorProvider method and a 
getFontProvider method which would not break anyone.

Jean-Michel is this something you would do in the 3.1 timeframe?
Comment 8 Tod Creasey CLA 2004-08-30 11:23:24 EDT
This has been released to HEAD - it is now possible to decorate colours and 
text in an IDecoration.

Please note that this API is expermental and may be adjusted during the viewer 
work in 3.1.
Comment 9 Fabrizio Giustina CLA 2004-09-01 04:36:02 EDT
Also if the APIs are been released I still can't see any of the existing
decorator make use of this new feature (which actually was the subject for this
rfe).

I expected to see an option to choose background/foreground color for dirty/new
files for team providers in preferences->team->CVS->label decoration
and an option somewhere to choose background/foreground color for files with
warnings or errors in the package explorer (something like the screenshots
provided).

Do I have to open addictional bug report for those? To which component should I
assign them: team, cvs, jdt ui?
Comment 10 Tod Creasey CLA 2004-09-01 07:31:32 EDT
I'll move this to Team as they will provide the CVS support (sorry - should 
hav renamed this).
Comment 11 Jean-Michel Lemieux CLA 2004-09-20 19:01:19 EDT
You can know configure the font/color for ignored and outgoing resources. Moving
to JDT to consider something similar for markers in the packages view.
Comment 12 Markus Keller CLA 2004-09-21 04:27:01 EDT
Tod, how is arbitration done when multiple label decorators want to set
colors/font? Is it just random which one is used? I think there should be some
sort of defined prioritization or "merging" of colors, such that we can ensure
that e.g. error color is always more important than team color.

Note that the old decoration types allows multiple decorations for the same
element: text can only be added, but not replaced; images should only be small
overlays and let the rest of the icon alone.
Comment 13 Tod Creasey CLA 2004-09-21 07:53:54 EDT
We don't intend to change the suffix/prefix addition algorithm - replacing the 
text was not something people wanted to happen whenthey had no control over it 
due to a contributed decorator from another plug-in.

If there is conflict between the decorator and the font or color provider of 
the viewer the decorator takes precedent. If two decorators are trying to do 
the same thing or decorate the same quadrant we do not currently do any 
conflict resolution. See Bug 36007
Comment 14 Tod Creasey CLA 2004-09-21 07:55:02 EDT
BTW you could add a color or font provider to the packages view and then allow 
the CVS decorator to override it when they are on as the decorator takes 
precedence.
Comment 15 Tod Creasey CLA 2004-09-27 16:03:38 EDT
Closing are there is nothing else to do on our part.
Comment 16 Tod Creasey CLA 2004-11-05 08:11:31 EST
Verified that our support is in M3 (thanks for moving it back - I missed it in 
my test pass).