This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 544833 - Inactive committer clean up for Eclipse project (Equinox, Platform, JDT and PDE) for the 4.12 release
Summary: Inactive committer clean up for Eclipse project (Equinox, Platform, JDT and P...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: PMC (show other bugs)
Version: 4.11   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.12 RC2   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-26 11:17 EST by Lars Vogel CLA
Modified: 2020-05-29 09:06 EDT (History)
17 users (show)

See Also:


Attachments
dmegert commits in Feb 2018 (79.82 KB, image/png)
2019-03-22 12:37 EDT, Wayne Beaton CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-02-26 11:17:28 EST
Similar to Bug 530200, the PMC decided to cleanup again inactive committers.
Comment 1 Lars Vogel CLA 2019-02-26 11:21:24 EST
Webmaster, I used to be able to see the committer stats in the portal. Can you remind there where I find it? I used to see it similar to list in https://bugs.eclipse.org/bugs/show_bug.cgi?id=530200#c5
Comment 2 Eclipse Webmaster CLA 2019-02-26 11:31:14 EST
I'm not sure that we expose that information any more.

@Wayne, do you know where Lars can find this data?

-M.
Comment 3 Mikaël Barbero CLA 2019-02-26 11:34:00 EST
The only info I found is from the project page (e.g. https://projects.eclipse.org/projects/eclipse.platform/who), click on an active committer and you will see the last active date (e.g. https://projects.eclipse.org/content/lars-vogel-committer-eclipse-platform)
Comment 4 Lars Vogel CLA 2019-02-26 11:37:26 EST
Mikael, ist this the last active date or active since? If you look at Andrey, the date of 2016 is definitely not his last activity.
Comment 5 Mikaël Barbero CLA 2019-02-26 11:51:35 EST
no idea.
Comment 6 Wayne Beaton CLA 2019-02-28 15:33:16 EST
The "Active date" is the date that they joined the project. 

> @Wayne, do you know where Lars can find this data?

git shortlog --after='2018-02-28' --summary
Comment 7 Lars Vogel CLA 2019-02-28 15:39:58 EST
(In reply to Wayne Beaton from comment #6)
> The "Active date" is the date that they joined the project. 
> 
> > @Wayne, do you know where Lars can find this data?
> 
> git shortlog --after='2018-02-28' --summary

;-) this list all people not only committers. So the old portal info is lost without replacement?
Comment 8 Wayne Beaton CLA 2019-02-28 16:36:16 EST
(In reply to Lars Vogel from comment #7)
> ;-) this list all people not only committers. 

Start with the list of committers. Remove any names that appear in the git log.

> So the old portal info is lost
> without replacement?

If it helps, the old portal info was badly bogus.
Comment 9 Dani Megert CLA 2019-03-04 12:24:46 EST
(In reply to Wayne Beaton from comment #8)
> (In reply to Lars Vogel from comment #7)
> > ;-) this list all people not only committers. 
> 
> Start with the list of committers. Remove any names that appear in the git
> log.
> 
> > So the old portal info is lost
> > without replacement?
> 
> If it helps, the old portal info was badly bogus.
Is there any way the Foundation could help us to collect the data? We also want to do this for JDT, PDE and Equinox and it looks like it's a lot of manual work on our side to figure out inactive committers.
Comment 10 Dani Megert CLA 2019-03-04 12:28:30 EST
(In reply to Wayne Beaton from comment #6)
> The "Active date" is the date that they joined the project. 
> 
> > @Wayne, do you know where Lars can find this data?
> 
> git shortlog --after='2018-02-28' --summary
This is very painful. E.g. Platform has 12 repositories.
Comment 11 Dani Megert CLA 2019-03-19 10:59:00 EDT
(In reply to Dani Megert from comment #9)
> Is there any way the Foundation could help us to collect the data?
Ping!
Comment 12 Wayne Beaton CLA 2019-03-20 14:58:43 EDT
The "Project Report" pages are an experiment that I've been working on. They are restricted to "committer access only" because they're a little expensive to run (so don't share the link with non-committers). I decided to extend it to include the charts that are rendered on the committer/project pages in the PMI (e.g. [1]).

https://www.eclipse.org/projects/tools/report.php?id=eclipse

By way of expectation management, I'm only tinkering with this page at the moment. It's not linked into the rest of the site and it is not a supported service (yet) so the webdev folks can't help with it.

[1] https://projects.eclipse.org/content/dani-megert-committer-jdt-java-development-tools
Comment 13 Dani Megert CLA 2019-03-21 13:20:51 EDT
(In reply to Wayne Beaton from comment #12)
> The "Project Report" pages are an experiment that I've been working on. They
> are restricted to "committer access only" because they're a little expensive
> to run (so don't share the link with non-committers). I decided to extend it
> to include the charts that are rendered on the committer/project pages in
> the PMI (e.g. [1]).
> 
> https://www.eclipse.org/projects/tools/report.php?id=eclipse
I did not get any result after waiting for 5 minutes. Maybe due to general slowness of infra in the past days?
Comment 14 Wayne Beaton CLA 2019-03-21 14:20:32 EDT
(In reply to Dani Megert from comment #13)
> I did not get any result after waiting for 5 minutes. Maybe due to general
> slowness of infra in the past days?

I reverted a database optimization by accident. It should be better now. Try again.
Comment 15 Dani Megert CLA 2019-03-22 10:19:52 EDT
(In reply to Wayne Beaton from comment #14)
> (In reply to Dani Megert from comment #13)
> > I did not get any result after waiting for 5 minutes. Maybe due to general
> > slowness of infra in the past days?
> 
> I reverted a database optimization by accident. It should be better now. Try
> again.
I now get some data, but e.g. looking at
https://www.eclipse.org/projects/tools/report.php?id=eclipse.jdt
I don't see my commits to JDT that I did in 2018 and 2019.
Example: https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=87b61c66067a1bd1bda08b1226e5e69caa705a08
Comment 16 Wayne Beaton CLA 2019-03-22 12:37:55 EDT
Created attachment 277969 [details]
dmegert commits in Feb 2018
Comment 17 Dani Megert CLA 2019-03-22 12:41:37 EDT
(In reply to Wayne Beaton from comment #16)
> Created attachment 277969 [details]
> dmegert commits in Feb 2018
Sure, but what about other done later like the one I posted in my previous comment as an example?
Comment 18 Wayne Beaton CLA 2019-03-22 12:43:45 EDT
(In reply to Wayne Beaton from comment #16)
> Created attachment 277969 [details]
> dmegert commits in Feb 2018

Never mind. I looked harder and the problem is that the scale of the graph is too low. The volume of activity in the early days buries the single commits that you made in January and February of 2019 in the axis.
Comment 19 Dani Megert CLA 2019-03-22 12:48:42 EDT
(In reply to Wayne Beaton from comment #18)
> (In reply to Wayne Beaton from comment #16)
> > Created attachment 277969 [details]
> > dmegert commits in Feb 2018
> 
> Never mind. I looked harder and the problem is that the scale of the graph
> is too low. The volume of activity in the early days buries the single
> commits that you made in January and February of 2019 in the axis.
k. Can you fix it?

Another event that can be a problem is the merging of JDT.* sub-projects into JDT. Not sure whether the JDT.* commits are reflected in JDT. When going to https://www.eclipse.org/projects/tools/report.php?id=eclipse.jdt.ui I do not get any history data.
Comment 20 Wayne Beaton CLA 2019-03-22 12:55:15 EDT
> k. Can you fix it?

Not right now, no.

> Another event that can be a problem is the merging of JDT.* sub-projects
> into JDT. Not sure whether the JDT.* commits are reflected in JDT. When
> going to https://www.eclipse.org/projects/tools/report.php?id=eclipse.jdt.ui
> I do not get any history data.

For these charts, the data extracted from the repositories listed on the "Developer Resources" page are used. 

https://projects.eclipse.org/projects/eclipse.jdt/developer
Comment 21 Dani Megert CLA 2019-04-24 10:32:34 EDT
We decided in the PMC (April 16, https://wiki.eclipse.org/Eclipse/PMC) that we will retire those who did not do anything in the past 2 years.
Comment 22 Lars Vogel CLA 2019-04-24 10:38:08 EDT
(In reply to Dani Megert from comment #21)
> We decided in the PMC (April 16, https://wiki.eclipse.org/Eclipse/PMC) that
> we will retire those who did not do anything in the past 2 years.

IIRC our process is that we suggest a list of committers to retire.
We announce this via the eclipse-dev mailing list. If someone wants to keep his commit rights, this person must speak up in the bug report.
Comment 23 Dani Megert CLA 2019-04-24 10:51:30 EDT
(In reply to Lars Vogel from comment #22)
> (In reply to Dani Megert from comment #21)
> > We decided in the PMC (April 16, https://wiki.eclipse.org/Eclipse/PMC) that
> > we will retire those who did not do anything in the past 2 years.
> 
> IIRC our process is that we suggest a list of committers to retire.
> We announce this via the eclipse-dev mailing list. If someone wants to keep
> his commit rights, this person must speak up in the bug report.
Sure, like we always did. I just wanted to capture the inactivity period that we decided in the PMC call.
Comment 24 Dani Megert CLA 2019-05-02 11:24:45 EDT
Let me handle this for all projects. I just got the list of inactive committers for the last one year and will get the report for the last two years probably tomorrow.
Comment 25 Lars Vogel CLA 2019-05-02 11:31:38 EDT
Thanks, Dani.
Comment 26 Martin Lippert CLA 2019-05-06 11:50:15 EDT
I would like to keep my commit rights for Equinox
Comment 27 Dani Megert CLA 2019-05-06 11:59:42 EDT
Sent notification to relevant mailing lists, e.g. https://www.eclipse.org/lists/eclipse-dev/msg11078.html
Comment 28 Mike Wilson CLA 2019-05-06 13:49:56 EDT
I would like to keep my commit rights.
Comment 29 Stephan Herrmann CLA 2019-05-06 15:57:33 EDT
Listed as inactive:

> Jesper Moller

git log says:

commit 28580a8e9d83198ae2ddbe9029d9028144edb915
Author: Jesper Steen Møller <jesper@selskabet.org>
Date:   Wed Mar 7 18:07:33 2018 +0100

    Bug 531046: [10] ICodeAssist#codeSelect support for 'var'
    
    Change-Id: I1b428a0695b4a27e30a8d6370fcbe171fa95cde2
    Signed-off-by: Jesper Moller <jesper@selskabet.org>

?
Comment 30 Sravan Kumar Lakkimsetti CLA 2019-05-07 01:25:39 EDT
(In reply to Stephan Herrmann from comment #29)
> Listed as inactive:
> 
> > Jesper Moller
> 
> git log says:
> 
> commit 28580a8e9d83198ae2ddbe9029d9028144edb915
> Author: Jesper Steen Møller <jesper@selskabet.org>
> Date:   Wed Mar 7 18:07:33 2018 +0100
> 
>     Bug 531046: [10] ICodeAssist#codeSelect support for 'var'
>     
>     Change-Id: I1b428a0695b4a27e30a8d6370fcbe171fa95cde2
>     Signed-off-by: Jesper Moller <jesper@selskabet.org>
> 
> ?

There is a mismatch in the name. The name is committer list is Jesper Moller. In git log it is Jesper Steen Møller. This is the reason why we have Jasper's name listed as inactive
Comment 31 Dani Megert CLA 2019-05-07 03:44:44 EDT
(In reply to Sravan Kumar Lakkimsetti from comment #30)
> There is a mismatch in the name. The name is committer list is Jesper
> Moller. In git log it is Jesper Steen Møller. This is the reason why we have
> Jasper's name listed as inactive
Please adjust the job(s).
Comment 32 Steve Northover CLA 2019-05-07 09:14:13 EDT
I would like to keep my commit rights.
Comment 33 Carolyn MacLeod CLA 2019-05-07 09:46:03 EDT
I would like to keep my commit rights.
Comment 34 Silenio Quarti CLA 2019-05-07 10:01:34 EDT
I would like to keep my commit rights.
Comment 35 Curtis Windatt CLA 2019-05-07 10:07:25 EDT
I would like to keep my commit rights.
Comment 36 Bogdan Gheorghe CLA 2019-05-07 10:48:05 EDT
I would like to keep my commit rights.
Comment 37 Michael Rennie CLA 2019-05-07 12:57:01 EDT
I would like to keep my commit rights.
Comment 38 Grant Gayed CLA 2019-05-07 17:01:02 EDT
I would like to keep my commit rights.
Comment 39 Markus Keller CLA 2019-05-14 04:45:43 EDT
I would like to keep my commit rights.
Comment 40 Dani Megert CLA 2019-06-05 10:04:07 EDT
Here's the final list of commit rights that will be removed:

*** Equinox ***
Borislav Kapukaranov
Glyn Normington
Henrik Lindberg
Ian Bull
John Arthorne
John Duimovich
Kim Moir
Krzysztof Daniel
Lazar Kirchev
Meng Xin Zhu
Oleg Besedin
Pascal Rapicault
Pavlin Dobrev
Peter Kriens
Simon Kaegi
Stefan Liebig
Stefan Xenos
Stoyan Boshev
Susan McCourt
Ted Habeck
Teodor Todorov
Thomas Hallgren
Tobias Oberlies

*** Platform ***
David Williams
Duong Nguyen
Eric Moffatt
Martin Oberhuber
Mikaël Barbero
Thomas Schindl
Tony McCrary

*** JDT ***
Andrew Clement
Darin Wright
Walter Harley

*** PDE ***
Chris Aniszczyk
Darin Wright
John Arthorne
Pascal Rapicault
Comment 41 Dani Megert CLA 2019-06-05 10:52:29 EDT
(In reply to Dani Megert from comment #40)
> Here's the final list of commit rights that will be removed:
Done for Platform, JDT and PDE. I did not remove "Thomas Schindl" as I've seen commits in 2018. Will check why he ended up on the list.
Comment 42 Thomas Watson CLA 2019-06-05 11:41:52 EDT
Done for Equinox.
Comment 43 Thomas Watson CLA 2019-06-06 08:16:21 EDT
Go for Equinox.
Comment 44 Dani Megert CLA 2019-06-06 08:18:46 EDT
(In reply to Thomas Watson from comment #43)
> Go for Equinox.
Wrong bug report?
Comment 45 Thomas Watson CLA 2019-06-06 08:43:24 EDT
(In reply to Dani Megert from comment #44)
> (In reply to Thomas Watson from comment #43)
> > Go for Equinox.
> Wrong bug report?

yes