This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 544754 - 2019-03 (4.11) Acknowledgements
Summary: 2019-03 (4.11) Acknowledgements
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.11   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.11 RC2   Edit
Assignee: Platform-Releng-Inbox CLA
QA Contact:
URL: https://www.eclipse.org/eclipse/devel...
Whiteboard:
Keywords:
Depends on:
Blocks: 544566
  Show dependency tree
 
Reported: 2019-02-25 03:18 EST by Sravan Kumar Lakkimsetti CLA
Modified: 2019-03-05 04:41 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sravan Kumar Lakkimsetti CLA 2019-02-25 03:18:11 EST
See https://wiki.eclipse.org/Eclipse/Release_checklist for tips
Comment 1 Eclipse Genie CLA 2019-02-25 04:57:20 EST
New Gerrit change created: https://git.eclipse.org/r/137514
Comment 3 Sravan Kumar Lakkimsetti CLA 2019-02-25 05:09:09 EST
First version has been deployed. Can see the page here https://www.eclipse.org/eclipse/development/acknowledgements_4.11.php
Comment 4 Wim Jongman CLA 2019-02-25 06:38:07 EST
The compilation of the list of platform contributors has been broken since 4.9. I can tell because I was not mentioned. Maybe others are missing as well.
Comment 5 Andrey Loskutov CLA 2019-02-25 06:59:42 EST
I should be on JDT committers list, not on the JDT contributors list.

 (In reply to Wim Jongman from comment #4)
> The compilation of the list of platform contributors has been broken since
> 4.9. I can tell because I was not mentioned. Maybe others are missing as
> well.

You are on the committers list for the platform.
Comment 6 Wim Jongman CLA 2019-02-25 08:42:59 EST
(In reply to Andrey Loskutov from comment #5)
> I should be on JDT committers list, not on the JDT contributors list.
> 
>  (In reply to Wim Jongman from comment #4)
> > The compilation of the list of platform contributors has been broken since
> > 4.9. I can tell because I was not mentioned. Maybe others are missing as
> > well.
> 
> You are on the committers list for the platform.

I was referring to the list of people that contributed code to Platform at the beginning of the page. "Special thanks to the following list of people, in alphabetical order, who contributed code to the project:"
Comment 7 Dani Megert CLA 2019-02-25 08:50:14 EST
(In reply to Wim Jongman from comment #6)
> (In reply to Andrey Loskutov from comment #5)
> > I should be on JDT committers list, not on the JDT contributors list.
> > 
> >  (In reply to Wim Jongman from comment #4)
> > > The compilation of the list of platform contributors has been broken since
> > > 4.9. I can tell because I was not mentioned. Maybe others are missing as
> > > well.
> > 
> > You are on the committers list for the platform.
> 
> I was referring to the list of people that contributed code to Platform at
> the beginning of the page. "Special thanks to the following list of people,
> in alphabetical order, who contributed code to the project:"
We only list people who are not committers on Platform. That's why you (and all others listed under Platform committers) are not listed in that section.
Comment 8 Lars Vogel CLA 2019-02-25 08:54:59 EST
(In reply to Dani Megert from comment #7)
> (In reply to Wim Jongman from comment #6)
> > (In reply to Andrey Loskutov from comment #5)
> > > I should be on JDT committers list, not on the JDT contributors list.
> > > 
> > >  (In reply to Wim Jongman from comment #4)
> > > > The compilation of the list of platform contributors has been broken since
> > > > 4.9. I can tell because I was not mentioned. Maybe others are missing as
> > > > well.
> > > 
> > > You are on the committers list for the platform.
> > 
> > I was referring to the list of people that contributed code to Platform at
> > the beginning of the page. "Special thanks to the following list of people,
> > in alphabetical order, who contributed code to the project:"
> We only list people who are not committers on Platform. That's why you (and
> all others listed under Platform committers) are not listed in that section.

Would be nice to change that. Several committers like Wim, contribute in their unpaid time. Let's discuss tomorrow in the PMC call if we should simply thanks everyone who contributed code. This would also simply the update IMHO.
Comment 9 Wim Jongman CLA 2019-02-25 09:29:09 EST
(In reply to Lars Vogel from comment #8)

> > We only list people who are not committers on Platform. That's why you (and
> > all others listed under Platform committers) are not listed in that section.

I now understand. At Nebula [1], we acknowledge code contributors regardless of committer status. That was what I expected to see in this list as well. 


> simply thank everyone who contributed code. This would also simply the
> update IMHO.

+1 Being a committer does not mean much if you're not contributing.



[1] https://wiki.eclipse.org/Nebula/Releases/2.0.0/NaN#Acknowledgements
Comment 10 Dani Megert CLA 2019-02-25 09:34:55 EST
(In reply to Wim Jongman from comment #9)
> +1 Being a committer does not mean much if you're not contributing.
Sure. Of course we should only list committers that contributed. Didn't verify whether we currently do that. However, we usually deactivate inactive committers on a early basis. Which reminds me ;-).

I have no problem to merge the two categories.
Comment 11 Lars Vogel CLA 2019-02-25 09:42:05 EST
(In reply to Dani Megert from comment #10)
> (In reply to Wim Jongman from comment #9)
> > +1 Being a committer does not mean much if you're not contributing.
> Sure. Of course we should only list committers that contributed. Didn't
> verify whether we currently do that. However, we usually deactivate inactive
> committers on a early basis. Which reminds me ;-).
> 
> I have no problem to merge the two categories.

+1

FYI, I used to use git bash to find all contributors in a certain release and manually filtered them by the list of committers. Just using Git bash to find all who contributed code should be much easier.
Comment 12 Wim Jongman CLA 2019-02-25 10:02:56 EST
(In reply to Dani Megert from comment #10)

> Of course we should only list committers that contributed. Didn't

It already does that. So the page is clear. I just did not get it.

    Active Committers

    This Eclipse release was brought to you by the following committers. These
    committers were active at the time of the release (that is, one or more
    commits since previous release.)

> committers on a early basis. Which reminds me ;-).

LOL
Comment 13 Lars Vogel CLA 2019-02-26 11:23:19 EST
Today, the PMC decided that we will give thanks you to everyone (contributors and committers) if they contributed to a release.
Comment 14 Eclipse Genie CLA 2019-02-27 03:56:09 EST
New Gerrit change created: https://git.eclipse.org/r/137685
Comment 16 Sravan Kumar Lakkimsetti CLA 2019-02-27 03:58:48 EST
Updated Acknowledgement page with committers also included in the list of contributors
Comment 17 Dani Megert CLA 2019-03-01 10:40:28 EST
(In reply to Sravan Kumar Lakkimsetti from comment #16)
> Updated Acknowledgement page with committers also included in the list of
> contributors
Please remove the "Active Committers" section now.
Comment 18 Dani Megert CLA 2019-03-04 09:55:02 EST
(In reply to Dani Megert from comment #17)
> (In reply to Sravan Kumar Lakkimsetti from comment #16)
> > Updated Acknowledgement page with committers also included in the list of
> > contributors
> Please remove the "Active Committers" section now.
Ping!
Comment 19 Eclipse Genie CLA 2019-03-05 04:22:20 EST
New Gerrit change created: https://git.eclipse.org/r/138052
Comment 21 Sravan Kumar Lakkimsetti CLA 2019-03-05 04:41:00 EST
(In reply to Dani Megert from comment #17)
> (In reply to Sravan Kumar Lakkimsetti from comment #16)
> > Updated Acknowledgement page with committers also included in the list of
> > contributors
> Please remove the "Active Committers" section now.

Removed active committers section and published the new page