This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 544145 - Web Services Explorer fails to load correctly with 3.13.0 M2
Summary: Web Services Explorer fails to load correctly with 3.13.0 M2
Status: VERIFIED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Compendium (show other bugs)
Version: 4.11   Edit
Hardware: PC Mac OS X
: P2 normal (vote)
Target Milestone: 4.11 RC2   Edit
Assignee: Thomas Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-05 10:24 EST by Shane Clarke CLA
Modified: 2019-03-11 17:28 EDT (History)
4 users (show)

See Also:
tjwatson: pmc_approved+
tjwatson: review+


Attachments
WSE Chrome Console (218.17 KB, image/png)
2019-02-27 14:15 EST, Shane Clarke CLA
no flags Details
WSE Chrome Refresh (452.40 KB, image/png)
2019-02-28 12:47 EST, Shane Clarke CLA
no flags Details
Bundles WTP 3.13.0 M3 Eclipse 4.11 M1 (working) (47.43 KB, text/plain)
2019-02-28 12:50 EST, Shane Clarke CLA
no flags Details
Bundles WTP 3.13.0 M3 Eclipse 4.11 M3 (not working) (47.42 KB, text/plain)
2019-02-28 12:52 EST, Shane Clarke CLA
no flags Details
Screenshot of WSE with Nitin's patch applied (80.27 KB, image/png)
2019-03-01 15:52 EST, Keith Chong CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Shane Clarke CLA 2019-02-05 10:24:24 EST
Hit an issue with this weeks smoke test

http://build.eclipse.org/webtools/committers/wtp-R3.13.0-I/20190131070724/S-3.13.0.M2-20190131070724/

Tested with I20190203-1800 Eclipse Platform

The Web Services Explorer fails to fully load after using the Bottom Up and Top Down wizards and selecting Test.

No errors in the workspace Error Log.

Launching using an external browser (Chrome) and viewing the View > Developer >Developer Tools > Console

shows some errors including

Uncaught ReferenceError: setSelectedAnchorName is not defined
    at onload (wsdl_navigator_content.jsp:19)
Comment 1 Nitin Dahyabhai CLA 2019-02-05 17:00:00 EST
Can this be fixed for M2, and if not, M3?
Comment 2 Keith Chong CLA 2019-02-13 10:38:31 EST
Nitin, I'll have a look.
Comment 3 Keith Chong CLA 2019-02-27 13:06:38 EST
The 2018.12 (WTP 3.12) release is fine.

Installing last week's WTP 3.13 smoke test driver over the pre-reqs for 2018.12 was fine too.

The WSE had some EPL 2.0 copyright header changes, but these changes did not cause this problem.

So something in the base/pre-reqs changed.
Comment 4 Nitin Dahyabhai CLA 2019-02-27 13:56:13 EST
(In reply to Shane Clarke from comment #0)

> Launching using an external browser (Chrome) and viewing the View >
> Developer >Developer Tools > Console
> 
> shows some errors including
> 
> Uncaught ReferenceError: setSelectedAnchorName is not defined
>     at onload (wsdl_navigator_content.jsp:19)

What other errors were shown?
Comment 5 Shane Clarke CLA 2019-02-27 14:15:46 EST
Created attachment 277706 [details]
WSE Chrome Console

Attaching screenshot of WSE in Chrome showing errors in console
Comment 6 Nitin Dahyabhai CLA 2019-02-27 17:02:26 EST
Shane, when you reload the page, does the treeview.js file come back as status 200, but empty?

Can you both, Keith and Shane, check your installation's configuration details and list out the Jetty and Equinox bundles you have (sorted if you can manage it)? I'm curious if this is related to the problems we had with the Preview servers and adapters.
Comment 7 Shane Clarke CLA 2019-02-28 12:47:21 EST
Created attachment 277717 [details]
WSE Chrome Refresh

Attaching screenshot of Chrome console following refresh. Not seeing any references to treeview.js
Comment 8 Shane Clarke CLA 2019-02-28 12:50:17 EST
Created attachment 277718 [details]
Bundles WTP 3.13.0 M3 Eclipse 4.11 M1 (working)

Attaching list of bundles from this weeks 3.13.0 M3 driver working with 4.11 M1
Comment 9 Shane Clarke CLA 2019-02-28 12:52:12 EST
Created attachment 277719 [details]
Bundles WTP 3.13.0 M3 Eclipse 4.11 M3 (not working)

Attaching list of bundles from this weeks 3.13.0 M3 driver not working with 4.11 M3 (had it installed following smoke test - bug introduced between 4.11 M1 and 4.11 M2)
Comment 10 Eclipse Genie CLA 2019-02-28 16:57:01 EST
New Gerrit change created: https://git.eclipse.org/r/137833
Comment 11 Keith Chong CLA 2019-03-01 11:49:18 EST
Nitin, I tried out your patch, and it works fine now.  Thanks again for looking into this.
Comment 12 Keith Chong CLA 2019-03-01 15:52:35 EST
Created attachment 277737 [details]
Screenshot of WSE with Nitin's patch applied
Comment 13 Keith Chong CLA 2019-03-01 16:09:27 EST
Rerouted to Equinox.

Raymond, if you want to use the Web Services Explorer (WSE) as a test case, here is how to set it up:

1. Download a WTP 3.13 milestone/stable build here:
   https://download.eclipse.org/webtools/downloads/
   
   a) For the WTP zip, get wtp-repo
   b) Get an Eclipse SDK build (4.11 M3)
   c) At minimum, get the DataTools zip (1.14.100 is fine)
      and an M3-based build for EMF & XSD, and GEF 5
  
2. To launch the WSE, go to the Java EE perspective and select from the Run menu, the "Launch the Web Services Explorer" action.
Comment 14 Raymond Auge CLA 2019-03-01 16:14:07 EST
(In reply to Keith Chong from comment #13)
> Rerouted to Equinox.
> 
> Raymond, if you want to use the Web Services Explorer (WSE) as a test case,
> here is how to set it up:
> 
> 1. Download a WTP 3.13 milestone/stable build here:
>    https://download.eclipse.org/webtools/downloads/
>    
>    a) For the WTP zip, get wtp-repo
I don't know what this means.

>    b) Get an Eclipse SDK build (4.11 M3)
I can do that.

>    c) At minimum, get the DataTools zip (1.14.100 is fine)
>       and an M3-based build for EMF & XSD, and GEF 5
Can I get links for all these parts? I use none of these tools under normal circumstances so I have no idea where to find them.

>   
> 2. To launch the WSE, go to the Java EE perspective and select from the Run
> menu, the "Launch the Web Services Explorer" action.
Comment 15 Nitin Dahyabhai CLA 2019-03-04 08:58:14 EST
(In reply to Raymond Auge from comment #14)
> (In reply to Keith Chong from comment #13)
> > Rerouted to Equinox.
> > 
> > Raymond, if you want to use the Web Services Explorer (WSE) as a test case,
> > here is how to set it up:

Since nothing in the Web Services Explorer changed, you can install the 2018-12 release as a baseline from http://download.eclipse.org/releases/2018-12 and compare the behavior to 2019-03M3 from http://download.eclipse.org/staging/2018-12 . Installing the "Eclipse Java EE Developer Tools" feature under the big Web, XML, etc. category at the bottom should pull the necessary parts in. You don't need to create any projects in the workspace to just launch the explorer and, using an external browser, see that static resources are being sent with a HTTP 200 status but zero length.
Comment 16 Nitin Dahyabhai CLA 2019-03-04 09:13:29 EST
To fill in some the technical details, I'm reasonably sure it started with the block at https://github.com/eclipse/rt.equinox.bundles/blob/master/bundles/org.eclipse.equinox.http.servlet/src/org/eclipse/equinox/http/servlet/internal/HttpServiceRuntimeImpl.java#L518 from commit d8a9c1087. It replaced a block that handled the 'match == Match.DEFAULT_SERVLET ' dispatch case and now causes the pathInfo variable to remain null instead of being set to match the requestURI. When the dispatching falls through to org.eclipse.equinox.http.servlet.internal.servlet.ResourceServlet on static files, it can no longer use that pathInfo to find the static file inside of the bundle and serve it (because it was never assigned a value without that block, so ends up serving a zero-length of content). Since changing the HttpServiceRuntimeImpl broke tests and the correct URI is still sent into the ResourceServlet, the current proposed change is limited to the servlet itself.
Comment 17 Keith Chong CLA 2019-03-04 12:32:08 EST
Hi Raymond,

Nitin provided an alternate and easier way to get everything set up to reproduce the problem.

But, to answer your questions and to get the latest instead, here are more details

1a) Here is a direct link:

https://www.eclipse.org/downloads/download.php?file=/webtools/downloads/drops/R3.13.0/S-3.13.0.M3-20190221042828/wtp-repo-S-3.13.0.M3-20190221042828.zip


1c) Here are direct links

DTP:
https://www.eclipse.org/downloads/download.php?file=/datatools/updates/1.14.100.201805031905/dtp-repository-1.14.100.201805031905.zip

EMF + XSD
Click Download from here:
https://download.eclipse.org/modeling/emf/emf/builds/milestone/S201903030654/index.html

GEF:
http://www.eclipse.org/gef/download.php?file=/tools/gef/downloads/drops//5.0.400/I201903020302/GEF-Update-5.0.400.zip


Start Eclipse, select Help->Install Software for each of 1c) zips.  And then install the zip from 1a).
Comment 18 Thomas Watson CLA 2019-03-05 15:43:58 EST
I started a review at https://git.eclipse.org/r/#/c/138104/

I'm still unclear how this worked before.  But the fix seems to be pretty clear.  We were not handing resource registrations with "/" aliases correctly when mapping them to the http whiteboard.  There we need to convert the pattern to be "/*" for it to work.
Comment 19 Thomas Watson CLA 2019-03-06 10:17:40 EST
Fixed for 4.11
Comment 20 Eclipse Genie CLA 2019-03-06 13:52:16 EST
New Gerrit change created: https://git.eclipse.org/r/138104
Comment 22 Keith Chong CLA 2019-03-11 17:28:21 EDT
Verified using eclipse-SDK-4.11RC2