Community
Participate
Working Groups
Eclipse 2018-12 allows to use the "Add Required Plug-ins" button, even if a view filter is set. That is great! Currently the "Add Required Plug-ins" does consider the view filter, which I think is counter-intuitiv. In my example, I filtered by "jface" and added it. Afterwards I pressed "Add Required Plug-ins" and expected to have swt added. I suggest to consider all available plug-ins in "Add Required Plug-ins".
Julian, WDYT?
The plug-in tree improvements are not in 4.10 (-> Bug 441684). The add required button is still disabled there with an active filter. What build are you running? Please try an I-Build, the button should behave exactly like you want.
(In reply to Julian Honnen from comment #2) > The plug-in tree improvements are not in 4.10 (-> Bug 441684). The add > required button is still disabled there with an active filter. > > What build are you running? Please try an I-Build, the button should behave > exactly like you want. Eclipse SDK Version: 2019-03 (4.11) Build id: I20190106-1800 OS: Windows 10, v.10.0, x86_64 / win32 Java version: 1.8.0_191 To test: Create a new e4 RCP application (using the e4 RCP template) Start it via the generated product Open the launch configuration and remove SWT Filter for jface and press Add Required Plug-ins -> SWT is not addded
Julian, are you able to reproduce?
Created attachment 277088 [details] screencap No, those exact steps work for me on that build (see attached screencap). Anything you're doing differently?
Created attachment 277132 [details] Example project Still does not work for me. I'm testing on Windows (no idea how to do a screencast here) but will repeat soon the test on Linux (for which I can provide a screencast). Test I do: Import attached project and start via the product Go to launch configuration and remove SWT and press validate -> errors are reported Add filter for jface -> Press add required plug-ins Press Validate again -> Still errors If I remove the filter and press Add required plug-in the validate does not report problems anymore.
Created attachment 277133 [details] Screencast on Linux demonstrating the issue
It seems like the result of the validation depends on the visible plugins. I get different problems depending on the filter. Add required seems to work in your screencap. The selected plugin count goes back up to 293.
Saving into working copy broke with the new tree implementation from Bug 441684: only selected *and visible* plugins are written to working copy. -> PluginBlock#savePluginState
*** Bug 543416 has been marked as a duplicate of this bug. ***
New Gerrit change created: https://git.eclipse.org/r/135040
Blocker due bug 441684 regression.
Gerrit change https://git.eclipse.org/r/135040 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=76e4ebcb2d7c9bdb261f8a1107e8441e3b4c6ed4
Thanks, Julian for the fast fix.
Can bug reporter or bug assignee please verify this defect for 4.11M3?
Works for me.
