Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 539987 - Provide build feedback for GH PRs
Summary: Provide build feedback for GH PRs
Status: CLOSED WORKSFORME
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: CI-Jenkins (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: CI Admin Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 537284
  Show dependency tree
 
Reported: 2018-10-10 05:27 EDT by Karsten Thoms CLA
Modified: 2018-10-10 12:04 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karsten Thoms CLA 2018-10-10 05:27:31 EDT 
This is a follow-up bug for https://bugs.eclipse.org/bugs/show_bug.cgi?id=537284#c25

The xtext-lib project is configured to set up jobs for PRs. There is currently one PR job:
   https://jenkins.eclipse.org/xtext/job/xtext-lib/view/change-requests/job/PR-120/

It is expected that build results are reported to the Checks section of the PR:
   https://github.com/eclipse/xtext-lib/pull/120

There is such feedback already, but it originates from the old JIPP. We need the same integration for the new infrastructure.
Comment 1 Frederic Gurr CLA 2018-10-10 11:53:01 EDT 
Feedback from the new JIPP works, but since it has the same name (continuous-integration/jenkins/pr-merge) as the one from the old JIPP they overwrite each other.

The name "continuous-integration/jenkins/pr-merge" is hard coded:
=> https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubNotificationContext.java#L150

Since the new JIPP will replace the old JIPP eventually I'm closing this as WORKSFORME.
Comment 2 Karsten Thoms CLA 2018-10-10 12:04:47 EDT 
OK, thanks for this note. Then we'll assume that it will work once we switch.