Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 539509 - Comparator errors in jdt bundles in I20180926-0830
Summary: Comparator errors in jdt bundles in I20180926-0830
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.9   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.10 M1   Edit
Assignee: Kalyan Prasad Tatavarthi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 539511 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-09-26 11:32 EDT by Jay Arthanareeswaran CLA
Modified: 2018-09-27 01:15 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Arthanareeswaran CLA 2018-09-26 11:32:56 EDT 
At the moment, only three bundles appear to be affected. Not clear to me what is causing it:

1.  eclipse.jdt.ui/org.eclipse.jdt.junit
   no-classifier: different
      org/eclipse/jdt/internal/junit/util/JUnitStubUtility.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [pack200, sources]

2.  eclipse.jdt.ui/org.eclipse.jdt.text.tests
   no-classifier: different
      org/eclipse/jdt/text/tests/BreakContinueTargetFinderTest.class: different
      org/eclipse/jdt/text/tests/MarkOccurrenceTest17.class: different
      org/eclipse/jdt/text/tests/MarkOccurrenceTest18.class: different
   classifier-sources: not present in baseline
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [pack200]
    The following attached artifacts are not present in the baseline and have been removed: [sources]

3.  eclipse.jdt.ui/org.eclipse.jdt.ui.tests.refactoring
   no-classifier: different
      org/eclipse/jdt/ui/tests/refactoring/BinaryReferencesTests.class: different
      org/eclipse/jdt/ui/tests/refactoring/DelegateCreatorTests.class: different
      org/eclipse/jdt/ui/tests/refactoring/InlineConstantTests.class: different
      org/eclipse/jdt/ui/tests/refactoring/InlineMethodTests.class: different
      org/eclipse/jdt/ui/tests/refactoring/ReplaceInvocationsTests.class: different
      org/eclipse/jdt/ui/tests/refactoring/typeconstraints/TypeEnvironmentTests.class: different
   classifier-sources: not present in baseline
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [pack200]
    The following attached artifacts are not present in the baseline and have been removed: [sources]

This has started happening after the Java 11 changes were merged.
Comment 1 Kalyan Prasad Tatavarthi CLA 2018-09-26 11:47:52 EDT 
*** Bug 539511 has been marked as a duplicate of this bug. ***
Comment 2 Eclipse Genie CLA 2018-09-26 12:02:10 EDT 
New Gerrit change created: https://git.eclipse.org/r/130030
Comment 4 Eclipse Genie CLA 2018-09-26 12:33:03 EDT 
New Gerrit change created: https://git.eclipse.org/r/130032
Comment 5 Eclipse Genie CLA 2018-09-26 12:48:18 EDT 
New Gerrit change created: https://git.eclipse.org/r/130033
Comment 6 Noopur Gupta CLA 2018-09-26 12:53:04 EDT 
Any idea what caused the comparator errors? Was there any change in the compiler? 

We were having green builds in JDT UI Gerrit until the BETA_JAVA11 merge today.
Comment 7 Kalyan Prasad Tatavarthi CLA 2018-09-26 13:03:04 EDT 
Had a look at the artifactscomarisons.zip available at http://download.eclipse.org/eclipse/downloads/drops4/I20180926-0830/buildlogs.php

The reason seems to be the change in the field IASTSharedValues.SHARED_AST_LEVEL from AST.JLS10 to AST.JLS11

So the comparison of the old and new files in artifactsComparison.zip shows that the difference in comparison occurs when this variable is used.

So 
Gerrit change https://git.eclipse.org/r/130030 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=f5400bf045d70a56178c9922e86e7f5ecff24038

Should fix this issue.