Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 539274 - Test_org_eclipse_swt_widgets_Shell.test_activateEventSend() doesn't compile on Windows
Summary: Test_org_eclipse_swt_widgets_Shell.test_activateEventSend() doesn't compile o...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.9   Edit
Hardware: PC Windows All
: P3 normal (vote)
Target Milestone: 4.10 M1   Edit
Assignee: Ed Merks CLA
QA Contact: Niraj Modi CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-20 05:35 EDT by Ed Merks CLA
Modified: 2018-10-10 02:18 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Merks CLA 2018-09-20 05:35:46 EDT 
Test_org_eclipse_swt_widgets_Shell.test_activateEventSend() uses org.eclipse.swt.internal.gtk.OS which is not available on Windows.

It should use SwtTestUtil.isX11.

Note that there's no 4.10 version in Bugzilla, so I hade to use 4.9.
Comment 1 Ed Merks CLA 2018-09-20 05:40:12 EDT 
The review didn't seem to be automatically attached:

https://git.eclipse.org/r/#/c/129713/
Comment 3 Niraj Modi CLA 2018-09-20 06:00:21 EDT 
Below commit via bug 436841 caused this problem:
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=ae69be6c3c1008e9517e8550424a0fd0d34b866d

(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/129713 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=76032e9506b6cedc19d4e13d0c940f40dd3924fd

Thanks Ed for the quick fix, resolving now.
Comment 4 Ed Merks CLA 2018-09-20 07:00:39 EDT 
Thanks for the super quick turn around!
Comment 5 Niraj Modi CLA 2018-10-10 02:18:56 EDT 
Verified in I20181008-1800.