Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 537899 - Improve AbstractSWTBot.dragAndDrop capability
Summary: Improve AbstractSWTBot.dragAndDrop capability
Status: VERIFIED FIXED
Alias: None
Product: SWTBot
Classification: Technology
Component: SWTBot (show other bugs)
Version: 2.7.0   Edit
Hardware: PC Windows 10
: P3 enhancement (vote)
Target Milestone: 2.8.0   Edit
Assignee: Laurent Redor CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 542480
  Show dependency tree
 
Reported: 2018-08-13 07:26 EDT by Laurent Redor CLA
Modified: 2019-01-15 02:32 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2018-08-13 07:26:21 EDT 
Currently, org.eclipse.swtbot.swt.finder.widgets.AbstractSWTBot.dragAndDrop(AbstractSWTBot<? extends Widget>) allows to drag'n'drop an AbstractSWTBot to a Widget. But the drop is made on the center of the widget.
The goal of this enhancement is to allow to drop at a specified location.
Comment 1 Eclipse Genie CLA 2018-08-13 07:27:33 EDT 
New Gerrit change created: https://git.eclipse.org/r/127340
Comment 2 Mickael Istria CLA 2018-09-20 05:22:59 EDT 
@Laurent

> The goal of this enhancement is to allow to drop at a specified location.

What's the user-story behind it? Do you need an absolute location, or a specified location inside the target widget (ie a relative one)?
Comment 3 Laurent Redor CLA 2018-09-25 09:34:50 EDT 
(In reply to Mickael Istria from comment #2)
> @Laurent
> 
> > The goal of this enhancement is to allow to drop at a specified location.
> 
> What's the user-story behind it? Do you need an absolute location, or a
> specified location inside the target widget (ie a relative one)?

As explained in comment review of patch set 4 [1], I don't need the absolute coordinates:

> The original method dragAndDrop(AbstractSWTBot<? extends Widget>) used absolute coordinates. This is why I proposed both.
> In my case, I use relative coordinates.

So if it is simpler for everybody, I can remove the absolute case. Or I can made the changes proposed by Mickael.

[1] https://git.eclipse.org/r/#/c/127340/4..4/org.eclipse.swtbot.swt.finder/src/org/eclipse/swtbot/swt/finder/widgets/AbstractSWTBot.java@1001
Comment 5 Patrick Tasse CLA 2018-09-25 12:11:56 EDT 
Merged to master branch.
Comment 6 Laurent Redor CLA 2019-01-15 02:32:29 EST 
The version "http://download.eclipse.org/technology/swtbot/milestones/2018-12-m3", including this fix, has been tested for Sirius with bugzilla 542480. This fix is OK for us.