Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 537717 - Marketplace Client does not open when theming is disabled
Summary: Marketplace Client does not open when theming is disabled
Status: CLOSED DUPLICATE of bug 536524
Alias: None
Product: MPC
Classification: Technology
Component: wizard (show other bugs)
Version: 1.7.0   Edit
Hardware: All All
: P3 normal with 1 vote (vote)
Target Milestone: 1.7.2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-06 06:53 EDT by Pierre-Yves Bigourdan CLA
Modified: 2018-09-18 08:44 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre-Yves Bigourdan CLA 2018-08-06 06:53:31 EDT
Since upgrading to Eclipse Photon, it seems to be no longer possible to launch the Marketplace Client when Eclipse theming is disabled. Note that I have tried upgrading to the latest version of MPC via the update site (http://download.eclipse.org/mpc/photon), without any luck. See the following stacktrace:

!ENTRY org.eclipse.ui 4 0 2018-08-06 11:36:02.235
!MESSAGE Unhandled event loop exception
!STACK 0
org.eclipse.e4.core.di.InjectionException: java.lang.NullPointerException
	at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:65)
	at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:318)
	at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:252)
	at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:161)
	at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:494)
	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:487)
	at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:204)
	at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:433)
	at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.handleWidgetSelection(AbstractContributionItem.java:446)
	at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.lambda$2(AbstractContributionItem.java:472)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4247)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1508)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1531)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1516)
	at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1320)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4091)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3712)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1170)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1059)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:667)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:597)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:152)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:656)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:592)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1498)
Caused by: java.lang.NullPointerException
	at org.eclipse.epp.internal.mpc.ui.css.StyleHelper.applyStyles(StyleHelper.java:184)
	at org.eclipse.epp.internal.mpc.ui.wizards.CatalogSwitcher.refreshSelection(CatalogSwitcher.java:189)
	at org.eclipse.epp.internal.mpc.ui.wizards.CatalogSwitcher.setSelection(CatalogSwitcher.java:178)
	at org.eclipse.epp.internal.mpc.ui.wizards.MarketplacePage.createMarketplaceSwitcher(MarketplacePage.java:660)
	at org.eclipse.epp.internal.mpc.ui.wizards.MarketplacePage.createControl(MarketplacePage.java:261)
	at org.eclipse.jface.wizard.Wizard.createPageControls(Wizard.java:176)
	at org.eclipse.jface.wizard.WizardDialog.createPageControls(WizardDialog.java:682)
	at org.eclipse.jface.wizard.WizardDialog.createContents(WizardDialog.java:574)
	at org.eclipse.jface.window.Window.create(Window.java:426)
	at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1096)
	at org.eclipse.jface.window.Window.open(Window.java:783)
	at org.eclipse.epp.internal.mpc.ui.commands.AbstractMarketplaceWizardCommand.openWizardDialog(AbstractMarketplaceWizardCommand.java:145)
	at org.eclipse.epp.internal.mpc.ui.commands.AbstractMarketplaceWizardCommand.execute(AbstractMarketplaceWizardCommand.java:72)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:291)
	at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:93)
	at jdk.internal.reflect.GeneratedMethodAccessor161.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
	... 39 more

Related StackOverflow thread: https://stackoverflow.com/questions/51083994/eclipse-photon-marketplace-client-can-not-be-opened/51101502
Comment 1 Pierre-Yves Bigourdan CLA 2018-08-14 17:36:14 EDT
Digging through the code, I noticed that commit 38011fad107f4947b3138af9fd23955007d44a16 most likely already addresses this, nevertheless it has not yet been released on the update site. Bug 536524 is probably similar to this one, but unfortunately it seems to be private (the following is displayed: "You are not authorized to access bug #536524.").
Comment 2 Martijn Dashorst CLA 2018-09-18 08:00:52 EDT
Similarly when dropping a item from the Marketplace website onto Eclipse, having theming disabled causes a NPE as well, in a different location, but still related to the same issue.


java.lang.NullPointerException
	at org.eclipse.epp.internal.mpc.ui.css.StyleHelper.applyStyles(StyleHelper.java:184)
	at org.eclipse.epp.internal.mpc.ui.wizards.CatalogSwitcher.refreshSelection(CatalogSwitcher.java:189)
	at org.eclipse.epp.internal.mpc.ui.wizards.CatalogSwitcher.setSelection(CatalogSwitcher.java:178)
	at org.eclipse.epp.internal.mpc.ui.wizards.MarketplacePage.createMarketplaceSwitcher(MarketplacePage.java:660)
	at org.eclipse.epp.internal.mpc.ui.wizards.MarketplacePage.createControl(MarketplacePage.java:261)
	at org.eclipse.jface.wizard.Wizard.createPageControls(Wizard.java:176)
	at org.eclipse.jface.wizard.WizardDialog.createPageControls(WizardDialog.java:682)
	at org.eclipse.jface.wizard.WizardDialog.createContents(WizardDialog.java:574)
	at org.eclipse.jface.window.Window.create(Window.java:426)
	at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1096)
	at org.eclipse.jface.window.Window.open(Window.java:783)
	at org.eclipse.epp.internal.mpc.ui.commands.AbstractMarketplaceWizardCommand.openWizardDialog(AbstractMarketplaceWizardCommand.java:145)
	at org.eclipse.epp.internal.mpc.ui.commands.AbstractMarketplaceWizardCommand.execute(AbstractMarketplaceWizardCommand.java:72)
	at org.eclipse.epp.mpc.ui.MarketplaceUrlHandler.triggerInstall(MarketplaceUrlHandler.java:224)
	at org.eclipse.epp.internal.mpc.ui.wizards.MarketplaceDropAdapter.proceedInstallation(MarketplaceDropAdapter.java:171)
	at org.eclipse.epp.internal.mpc.ui.wizards.MarketplaceDropAdapter$MarketplaceDropTargetListener.lambda$0(MarketplaceDropAdapter.java:296)
Comment 3 Carsten Reckord CLA 2018-09-18 08:44:53 EDT
Hey everyone, MPC 1.7.2 has been released and fixes this issue. 

Updates are available from
http://download.eclipse.org/mpc/photon
http://download.eclipse.org/mpc/2018-09

or directly from http://download.eclipse.org/mpc/releases/1.7.2

*** This bug has been marked as a duplicate of bug 536524 ***