Comment 1 Thorsten Schöning 2018-06-28 08:56:09 EDT

The same happens when opening the Marketplace manually using "Help/Eclipse Marketplace..." and yes, the problem is the space in our examples, but it might be other characters as well. As in some other cases already documented in this bug tracker, what is defined to be a path is wrongly interpreted as an URI somewhere without properly transforming between both. This was newly introduced in Photon 4.8.0 and worked properly in the former release. What I'm doing is starting Eclipse the following way:

> "C:\Program Files\Eclipse\eclipse.exe" -configuration "%APPDATA%\Eclipse\Java GitHub\configuration" -data "%USERPROFILE%\Documents\Eclipse\Java GitHub"

The space doesn't seem to be an issue for the workspace, but for the configuration-data. Changing "Java GitHub" to "Java%20GitHub" for "configuration" doesn't work as well, because in that case a directory named "Java%20GitHub" gets created. Doing the same for the workspace keeps "Java GitHub", so the path is clearly handled differently in both cases and what is done for "configuration" is wrong. Both switches are documented to accept a path(!) and that needs to be transformed to an URI internally properly if needed, which is not the case currently somewhere related to the Marketplace.

http://help.eclipse.org/kepler/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fmisc%2Fruntime-options.html&cp=2_1_3_0&anchor=locations

> org.eclipse.e4.core.di.InjectionException: java.lang.IllegalArgumentException: Illegal character in path at index 54: file:/C:/Users/[...]/AppData/Roaming/Eclipse/Java GitHub/configuration/
> 	at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:65)
> 	at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:318)
> 	at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:252)
> 	at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:161)
> 	at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
> 	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:494)
> 	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:487)
> 	at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:204)
> 	at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:433)
> 	at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.handleWidgetSelection(AbstractContributionItem.java:446)
> 	at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.lambda$2(AbstractContributionItem.java:472)
> 	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
> 	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4118)
> 	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1052)
> 	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3931)
> 	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3534)
> 	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1170)
> 	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> 	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1059)
> 	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
> 	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:667)
> 	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> 	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:597)
> 	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
> 	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:152)
> 	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
> 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:656)
> 	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:592)
> 	at org.eclipse.equinox.launcher.Main.run(Main.java:1498)
> Caused by: java.lang.IllegalArgumentException: Illegal character in path at index 54: file:/C:/Users/[...]/AppData/Roaming/Eclipse/Java GitHub/configuration/
> 	at java.net.URI.create(URI.java:852)
> 	at org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceInfo.computeConfigurationAreaRegistryFile(MarketplaceInfo.java:445)
> 	at org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceInfo.createRegistryFile(MarketplaceInfo.java:408)
> 	at org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceInfo.load(MarketplaceInfo.java:341)
> 	at org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceInfo.getInstance(MarketplaceInfo.java:330)
> 	at org.eclipse.epp.internal.mpc.ui.catalog.MarketplaceDiscoveryStrategy.<init>(MarketplaceDiscoveryStrategy.java:109)
> 	at org.eclipse.epp.internal.mpc.ui.wizards.MarketplaceWizard.initializeCatalog(MarketplaceWizard.java:922)
> 	at org.eclipse.epp.internal.mpc.ui.wizards.MarketplacePage.setVisible(MarketplacePage.java:831)
> 	at org.eclipse.jface.wizard.WizardDialog.showStartingPage(WizardDialog.java:1220)
> 	at org.eclipse.jface.wizard.WizardDialog.createContents(WizardDialog.java:576)
> 	at org.eclipse.jface.window.Window.create(Window.java:426)
> 	at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1096)
> 	at org.eclipse.jface.window.Window.open(Window.java:783)
> 	at org.eclipse.epp.internal.mpc.ui.commands.AbstractMarketplaceWizardCommand.openWizardDialog(AbstractMarketplaceWizardCommand.java:145)
> 	at org.eclipse.epp.internal.mpc.ui.commands.AbstractMarketplaceWizardCommand.execute(AbstractMarketplaceWizardCommand.java:72)
> 	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:291)
> 	at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:93)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
> 	... 36 more
> Caused by: java.net.URISyntaxException: Illegal character in path at index 54: file:/C:/Users/[...]/AppData/Roaming/Eclipse/Java GitHub/configuration/
> 	at java.net.URI$Parser.fail(URI.java:2848)
> 	at java.net.URI$Parser.checkChars(URI.java:3021)
> 	at java.net.URI$Parser.parseHierarchical(URI.java:3105)
> 	at java.net.URI$Parser.parse(URI.java:3053)
> 	at java.net.URI.<init>(URI.java:588)
> 	at java.net.URI.create(URI.java:850)
> 	... 57 more

Comment 2 Thorsten Schöning 2018-06-28 09:17:16 EDT

Just stumbled upon the following bug where the problem is addressed as well, so it might be worth to close this one as a duplicate of the referenced one:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=536385

Comment 3 Carsten Reckord 2018-06-28 12:00:02 EDT

The unknown files search definitely adds another angle to it, but this is bug 536385.

*** This bug has been marked as a duplicate of bug 536385 ***