Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 53609 - [EditorMgmt] drop-down: dropdown contains current editor
Summary: [EditorMgmt] drop-down: dropdown contains current editor
Status: CLOSED DUPLICATE of bug 370441
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-03 09:51 EST by Michael Van Meekeren CLA
Modified: 2013-02-11 13:13 EST (History)
3 users (show)

See Also:


Attachments
pic (41.01 KB, image/pjpeg)
2004-03-03 09:51 EST, Michael Van Meekeren CLA
no flags Details
pic (41.01 KB, image/pjpeg)
2004-03-03 09:51 EST, Michael Van Meekeren CLA
no flags Details
Resolves bugs 54071 and 53609 (7.17 KB, patch)
2004-04-22 14:50 EDT, Hanna Farah CLA
no flags Details | Diff
Fixes bug 53609 according to comment #8 (2.20 KB, patch)
2004-06-02 17:33 EDT, Hanna Farah CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Van Meekeren CLA 2004-03-03 09:51:00 EST
build I20040302

If I pull down the editor drop down selection list when in single mode there 
are three items, one being the current item, however the Ctabfolder indicates 
a number 2 below the chevron to indicate there are two hidden files.

I think the list should not show the current file, this makes the list size 
match the number by the chevron, and removes a redundant option.

attached a picture of this
Comment 1 Michael Van Meekeren CLA 2004-03-03 09:51:22 EST
Created attachment 8299 [details]
pic
Comment 2 Michael Van Meekeren CLA 2004-03-03 09:51:40 EST
Created attachment 8300 [details]
pic
Comment 3 Michael Van Meekeren CLA 2004-04-19 12:40:20 EDT
The dropdown should differentiate between the visible items and the ones that 
are not visible by sorting them into to groups and putting the non-visible 
items on the top then some sort of separator (or bolding them) then the rest.
Comment 4 Hanna Farah CLA 2004-04-22 14:50:52 EDT
Created attachment 9878 [details]
Resolves bugs 54071 and 53609
Comment 5 Kim Horne CLA 2004-04-22 16:01:50 EDT
Patch committed.
Comment 6 Michael Van Meekeren CLA 2004-04-29 14:10:46 EDT
The bold text seems a little strong especially for the single tabbed editor 
where ALL items will always be bold except for the item representing the 
currently open editor.

I think we should change to use italic font for the open tabs and normal for 
the rest while keeping the same sort order we have now... OR put a separator 
between the two types and drawing them both normally otherwise.
Comment 7 Kim Horne CLA 2004-05-03 16:15:23 EDT
Fix in HEAD.
Comment 8 Michael Van Meekeren CLA 2004-05-31 11:13:25 EDT
re-opening, the italics just do not stand out, and secondly we are using 
italics in other parts of the workbench to mean "busy" as in.. I'm 
syncronizing now,, don't click on these.

I think we should revert one of the following: 

A- remove italics, let all look the same
B- use bold for items that are not visible but ONLY for the multi-tab case, 
for single tab we do nothing.

any opinions?
Comment 9 Hanna Farah CLA 2004-06-02 17:33:35 EDT
Created attachment 11502 [details]
Fixes bug 53609 according to comment #8

This patch conforms to comment #8.
Comment 10 Michael Van Meekeren CLA 2004-06-03 14:59:30 EDT
fixed in HEAD
Comment 11 Michael Van Meekeren CLA 2004-06-03 15:00:27 EDT
marking as 3.1, we should use the Jface support to bold the font if possible.
Comment 12 Debbie Wilson CLA 2004-06-09 11:01:27 EDT
Verified that all work to comment 10 is complete and available in I20040609 
(0800).
Comment 13 Hanna Farah CLA 2004-06-28 13:38:59 EDT
Leaving as is until there is public API to get the bold version of a font.
Comment 14 Douglas Pollock CLA 2004-09-28 12:10:06 EDT
Hanna no longer works for us. 
Comment 15 Dan Berindei CLA 2005-06-17 11:40:26 EDT
I am using a single tab and I see all see all the file names as bold (except for
the current one).

I would rather there was no indication of "hidden" files, just like in the
Next/Previous Editor dialog.
Comment 16 Michael Van Meekeren CLA 2006-04-21 13:19:04 EDT
Moving Dougs bugs
Comment 17 Susan McCourt CLA 2009-07-09 19:03:55 EDT
As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009
Comment 18 Boris Bokowski CLA 2009-11-17 13:00:24 EST
Remy is now responsible for watching the [EditorMgmt] component area.
Comment 19 Curtis Windatt CLA 2013-02-11 13:13:06 EST
Editor management has gone through a lot of changes since this bug was opened.  Marking as a duplicate of a more recent discussion of what the editor drop down should show.

Bug 370441 - Allow to see all editors in ">>" drop-down

*** This bug has been marked as a duplicate of bug 370441 ***