Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 535947 - SearchField-free quick access misses "Previous Choices" list
Summary: SearchField-free quick access misses "Previous Choices" list
Status: CLOSED DUPLICATE of bug 495065
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-15 09:05 EDT by Andrey Loskutov CLA
Modified: 2018-06-16 16:02 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2018-06-15 09:05:29 EDT 
While reviewing the patch for bug 535679 I had to use quick access *search field* which I usually hide. 

I've noticed that we have this "Previous Choices" list initially ONLY in the "visible" search field, not in the dialog which is shown while quick access search field is hidden.

This must be a bug. "Previous Choices" list should be shown independently from the fact if the quick assist search field is shown or not on the toolbar.
Comment 1 Patrik Suzzi CLA 2018-06-16 11:22:57 EDT 
The quick access shown in the toolbar is implemented through SearchField, while when the toolbar is not visible, it is implemented via the QuickAccessDialog.

- QuickAccessDialog is the standalone dialog (legacy implementation)

- SearchField is the new search dialog. Its context is created only when the search field is visible on the toolbar (there is a focus listener)

I am pretty sure there is already a bug pointing the issue that the legacy search dialog has a previous pick list disjoint w.r.t the new "E4" search dialog, i believe it is bug 495065
Comment 2 Patrik Suzzi CLA 2018-06-16 16:02:12 EDT 

*** This bug has been marked as a duplicate of bug 495065 ***